Raise meaningful error when bequeath is attempted in thin mode (which is

unsupported).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -37,6 +37,9 @@ Thin Mode Changes
     server certificate match the host name used to connect to the database.
 #)  The text of error ``DPY-4022: invalid value for DRCP purity {purity}``
     changed to ``DPY-4022: invalid value for enumeration {name}: {value}``.
+#)  Error ``DPY-3001: bequeath is only supported in python-oracledb thick
+    mode`` is now raised when attempting to connect to the database without a
+    connect string.
 #)  Internal change: improve low-level encoding and decoding routines.
 #)  Internal change: send buffer length for bind variables without unneeded
     adjustment.

src/oracledb/impl/thin/connection.pyx

@@ -358,7 +358,11 @@ cdef class ThinConnImpl(BaseThinConnImpl):
             Address address
         num_lists = len(description.active_children)
         num_attempts = description.retry_count + 1
-        connect_string = _get_connect_data(description, self._connection_id, params)
+        connect_string = _get_connect_data(description, self._connection_id,
+                                           params)
+        if connect_string is None:
+            errors._raise_err(errors.ERR_FEATURE_NOT_SUPPORTED,
+                              feature="bequeath", driver_type="thick")
         for i in range(num_attempts):
             for j, address_list in enumerate(description.active_children):
                 num_addresses = len(address_list.active_children)

tests/test_7300_unsupported_features_thin.py

@@ -28,6 +28,7 @@
 
 import unittest
 
+import oracledb
 import test_env
 
 
@@ -58,6 +59,14 @@ def test_7302(self):
         with self.assertRaisesFullCode("DPY-3001"):
             test_env.get_connection(supershardingkey=[17, 23])
 
+    def test_7303(self):
+        "7303 - test connect() without a connect string (bequeath)"
+        with self.assertRaisesFullCode("DPY-3001"):
+            oracledb.connect(
+                user=test_env.get_main_user(),
+                password=test_env.get_main_password(),
+            )
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()