Fixed bug when calling execute() or executemany() with missing bind data

after calling setinputsizes() with at least one of the parameters passed
as the value "None" (#217).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -25,6 +25,12 @@ Thick Mode Changes
 Common Changes
 ++++++++++++++
 
+#)  Fixed bug when calling :meth:`Cursor.execute()` or
+    :meth:`Cursor.executemany()` with missing bind data after calling
+    :meth:`Cursor.setinputsizes()` with at least one of the values supplied as
+    ``None``
+    (`issue 217 <https://github.com/oracle/python-oracledb/issues/217>`__).
+
 
 oracledb 1.4.0 (August 2023)
 ----------------------------

src/oracledb/impl/base/cursor.pyx

@@ -322,8 +322,9 @@ cdef class BaseCursorImpl:
             BindVar bind_var
             ssize_t i
         for i, bind_var in enumerate(self.bind_vars):
-            bind_var.var_impl._bind(conn, self, num_execs, bind_var.name,
-                                    bind_var.pos)
+            if bind_var is not None and bind_var.var_impl is not None:
+                bind_var.var_impl._bind(conn, self, num_execs, bind_var.name,
+                                        bind_var.pos)
 
     cdef int _reset_bind_vars(self, uint32_t num_rows) except -1:
         """

tests/test_3900_cursor_execute.py

@@ -383,5 +383,13 @@ def type_handler(cursor, metadata):
         self.assertEqual(self.cursor.fetchall(),
                          [(1,), (2,), (3,), (4,), (5,)])
 
+    def test_3930_setinputsizes_no_binds(self):
+        "3930 - test setinputsizes() but without binding"
+        self.cursor.setinputsizes(None, int)
+        sql = "select :1, : 2 from dual"
+        self.assertRaisesRegex(oracledb.DatabaseError,
+                               "^ORA-01008:|^DPY-4010:",
+                               self.cursor.execute, sql, [])
+
 if __name__ == "__main__":
     test_env.run_test_cases()