The method cursor.setoutputsize() no longer needs to do anything (since ODPI-C

automatically manages buffer sizes of LONG and LONG RAW columns).

Author: anthony-tuininga

doc/src/cursor.rst

@@ -456,10 +456,9 @@ Cursor Object
 
 .. method:: Cursor.setoutputsize(size, [column])
 
-   This can be used before a call to :meth:`~Cursor.execute()` to predefine
-   memory areas for the long columns that will be fetched. The column is
-   specified as an index into the result sequence. Not specifying the column
-   will set the default size for all large columns in the cursor.
+   This method does nothing and is retained solely for compatibility with the
+   DB API. The module automatically allocates as much space as needed to fetch
+   LONG and LONG RAW columns (or CLOB as string and BLOB as bytes).
 
 
 .. attribute:: Cursor.statement

src/Cursor.c

@@ -31,8 +31,6 @@ typedef struct {
     uint32_t bindArraySize;
     uint32_t fetchArraySize;
     int setInputSizes;
-    int outputSize;
-    int outputSizeColumn;
     uint64_t rowCount;
     uint32_t fetchBufferRowIndex;
     uint32_t numRowsInFetchBuffer;
@@ -238,8 +236,6 @@ static int Cursor_Init(udt_Cursor *self, PyObject *args, PyObject *keywordArgs)
     self->arraySize = 100;
     self->fetchArraySize = 100;
     self->bindArraySize = 1;
-    self->outputSize = -1;
-    self->outputSizeColumn = -1;
     self->isOpen = 1;
 
     return 0;
@@ -436,13 +432,6 @@ static int Cursor_PerformDefine(udt_Cursor *self, uint32_t numQueryColumns)
                 return -1;
         }
 
-        // if setoutputsize() called, use its value instead
-        if (self->outputSize >= 0) {
-            if (self->outputSizeColumn < 0 ||
-                    (int) pos == self->outputSizeColumn)
-                size = self->outputSize;
-        }
-
         // determine the default type 
         varType = VarType_FromQueryInfo(&queryInfo);
         if (!varType)
@@ -1447,10 +1436,6 @@ static PyObject *Cursor_Execute(udt_Cursor *self, PyObject *args,
         }
     }
 
-    // reset the values of setoutputsize()
-    self->outputSize = -1;
-    self->outputSizeColumn = -1;
-
     // for queries, return the cursor for convenience
     if (numQueryColumns > 0) {
         Py_INCREF(self);
@@ -1827,15 +1812,15 @@ static PyObject *Cursor_SetInputSizes(udt_Cursor *self, PyObject *args,
 
 //-----------------------------------------------------------------------------
 // Cursor_SetOutputSize()
-//   Set the size of all of the long columns or just one of them.
+//   Does nothing as ODPI-C handles long columns dynamically without the need
+// to specify a maximum length.
 //-----------------------------------------------------------------------------
 static PyObject *Cursor_SetOutputSize(udt_Cursor *self, PyObject *args)
 {
-    self->outputSizeColumn = -1;
-    if (!PyArg_ParseTuple(args, "i|i", &self->outputSize,
-            &self->outputSizeColumn))
-        return NULL;
+    int outputSize, outputSizeColumn;
 
+    if (!PyArg_ParseTuple(args, "i|i", &outputSize, &outputSizeColumn))
+        return NULL;
     Py_RETURN_NONE;
 }
 

test/LongVar.py

@@ -78,27 +78,6 @@ def testLongRawCursorDescription(self):
                   ('LONGRAWCOL', cx_Oracle.LONG_BINARY, None, None, None, None,
                         0) ])
 
-    def testSetOutputSizesAll(self):
-        "test setoutputsizes is valid (all)"
-        self.cursor.setoutputsize(25000)
-        self.cursor.execute("select * from TestLongRaws")
-        longVar = self.cursor.fetchvars[1]
-        self.assertEqual(longVar.size, 25000)
-
-    def testSetOutputSizesWrongColumn(self):
-        "test setoutputsizes is valid (wrong column)"
-        self.cursor.setoutputsize(25000, 1)
-        self.cursor.execute("select * from TestLongs")
-        longVar = self.cursor.fetchvars[1]
-        self.assertEqual(longVar.size, 131072)
-
-    def testSetOutputSizesRightColumn(self):
-        "test setoutputsizes is valid (right column)"
-        self.cursor.setoutputsize(35000, 2)
-        self.cursor.execute("select * from TestLongRaws")
-        longVar = self.cursor.fetchvars[1]
-        self.assertEqual(longVar.size, 35000)
-
     def testArraySizeTooLarge(self):
         "test array size too large generates an exception"
         self.cursor.arraysize = 268435456

test/uLongVar.py

@@ -35,7 +35,6 @@ def __PerformTest(self, a_Type, a_InputType):
                     integerValue = i,
                     longString = longString)
         self.connection.commit()
-        self.cursor.setoutputsize(250000, 2)
         self.cursor.execute(u"""
                 select *
                 from Test%ss
@@ -75,20 +74,6 @@ def testLongRawCursorDescription(self):
                   (u'LONGRAWCOL', cx_Oracle.LONG_BINARY, None, None, None,
                         None, 0) ])
 
-    def testSetOutputSizesAll(self):
-        "test setoutputsizes is valid (all)"
-        self.cursor.setoutputsize(25000)
-        self.cursor.execute(u"select * from TestLongRaws")
-        longVar = self.cursor.fetchvars[1]
-        self.assertEqual(longVar.size, 25000)
-
-    def testSetOutputSizesWrongColumn(self):
-        "test setoutputsizes is valid (wrong column)"
-        self.cursor.setoutputsize(25000, 1)
-        self.cursor.execute(u"select * from TestLongRaws")
-        longVar = self.cursor.fetchvars[1]
-        self.assertEqual(longVar.size, 131072)
-
     def testArraySizeTooLarge(self):
         "test array size too large generates an exception"
         self.cursor.arraysize = 268435456