-
Notifications
You must be signed in to change notification settings - Fork 197
session authencation port is hardcoded #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@qtlin, so here I have gone through the code for creating user session, and what i have seen here @harshkumar-dev , @HamadaGabrIbrahim, @mross22, @vish1, @kernleee , @karthik-k-kamath Also opening a PR to solve this issue. Please also advise is there any security vulnerabilities with this dynamic approach. |
I mentioned this in #736 but this should be implemented as a command-line parameter not as a dynamic process. Having the ability to provide a specific port would allow users with restrictive firewalls to still use this process. |
I agree with @Djelibeybi that port must be configurable in advance or requested from command line in case 8181 is occupied for whatever reason. Right now the process fails if 8181 is not available. |
I have an internal branch with this implemented and working for I need to find the right folks in the Identity team to talk to about this, and it's already Friday here, so I'll probably resume again on Monday. |
ok, whatever it is let me know, whether the port selection should be don in advance or has to be requested from command line in case 8181 is occupied. |
If a port is occupied then next available or a random port must be selected instead of an error:
Could not complete bootstrap process because port xxxx is already in use.
The text was updated successfully, but these errors were encountered: