Skip to content

Commit fac7d5b

Browse files
committed
Improve clean-up handling in test files
1 parent 0680e29 commit fac7d5b

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

test/resultSet1.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
const oracledb = require('oracledb');
3434
const assert = require('assert');
3535
const dbConfig = require('./dbconfig.js');
36+
const testsUtil = require('./testsUtil.js');
3637

3738
describe('12. resultSet1.js', function() {
3839

@@ -627,6 +628,7 @@ describe('12. resultSet1.js', function() {
627628

628629
it('12.6.1 the amount and value of metaData should be correct', async function() {
629630

631+
const tableName = "nodb_tab_manycolumns";
630632
/* Helper functions */
631633
const StringBuffer = function() {
632634
this.buffer = [];
@@ -647,7 +649,7 @@ describe('12. resultSet1.js', function() {
647649

648650
const createTab = function(size) {
649651
const buffer = new StringBuffer();
650-
buffer.append("CREATE TABLE nodb_tab_manycolumns( ");
652+
buffer.append(`CREATE TABLE ${tableName} ( `);
651653

652654
for (let i = 0; i < size - 1; i++) {
653655
buffer.append("c" + i + " NUMBER, ");
@@ -660,18 +662,17 @@ describe('12. resultSet1.js', function() {
660662
/*********************/
661663
const columnsAmount = 1000;
662664

663-
const sql = createTab(columnsAmount);
664-
await conn.execute(sql);
665+
await testsUtil.createTable(conn, tableName, createTab(columnsAmount));
665666
const result = await conn.execute(
666-
"SELECT * FROM nodb_tab_manycolumns",
667+
`SELECT * FROM ${tableName}`,
667668
[],
668669
{ resultSet: true});
669670
const rs = result.resultSet;
670671
for (let i = 0; i < columnsAmount; i++) {
671672
assert.strictEqual(rs.metaData[i].name, 'C' + i);
672673
}
673674
await rs.close();
674-
await conn.execute("DROP TABLE nodb_tab_manycolumns PURGE");
675+
await testsUtil.dropTable(conn, tableName);
675676
});
676677

677678
it('12.6.2 can distinguish lower case and upper case', async function() {

0 commit comments

Comments
 (0)