Skip to content

Commit 2f8912e

Browse files
committed
Adding more tests and documentation
1 parent a848410 commit 2f8912e

File tree

4 files changed

+460
-6
lines changed

4 files changed

+460
-6
lines changed

doc/src/api_manual/pool.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ values.
3030
.. attribute:: pool.connectionsInUse
3131

3232
This read-only property is a number which specifies the number of
33-
currently active connections in the connection pool, that is, 
33+
currently active connections in the connection pool, that is,
3434
the number of connections currently “checked out” using
3535
``pool.getConnection()``.
3636

test/connection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ describe('1. connection.js', function() {
527527
}); //1.15
528528

529529
describe('1.16 error on empty connectString with thin mode', function() {
530-
before(async function() {
530+
before(function() {
531531
if (!oracledb.thin) {
532532
this.skip();
533533
}

test/fetchTypeHandler.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,19 +469,20 @@ describe('271. fetchTypeHandler.js', function() {
469469
await connection.execute(`INSERT INTO ${TABLE} values (01, 'ABC', 23,
470470
TO_TIMESTAMP('2023-04-27 10:30:00', 'YYYY-MM-DD HH24:MI:SS'))`);
471471
const result = await connection.execute(
472-
`SELECT id, name, age,
473-
created_date AS TS_DATE FROM ${TABLE}`,
472+
`SELECT id, name, age, created_date AS TS_DATE FROM ${TABLE}`,
474473
[],
475474
{
476475
outFormat: oracledb.OUT_FORMAT_OBJECT
477476
}
478477
);
479478

480-
assert.deepEqual(Object.getOwnPropertyNames(result.rows[0]), ["ID", "NAME", "AGE", "TS_DATE"]);
479+
assert.deepEqual(Object.getOwnPropertyNames(result.rows[0]),
480+
["ID", "NAME", "AGE", "TS_DATE"]);
481481
assert.deepEqual(result.rows[0].ID, "1");
482482
assert.deepEqual(result.rows[0].NAME, "ABC");
483483
assert.deepEqual(result.rows[0].AGE, "23");
484-
assert.deepEqual(result.rows[0].TS_DATE, new Date('2023-04-27T10:30:00.000Z'));
484+
assert.deepEqual(result.rows[0].TS_DATE, new Date('2023-04-27 10:30:00.000'));
485485
await connection.execute(testsUtil.sqlDropTable(TABLE));
486486
});
487+
487488
});

0 commit comments

Comments
 (0)