Import Buffer and process modules consistently as per PR #1559of Sławomir Osoba

Author: sharadraju

doc/src/release_notes.rst

@@ -21,6 +21,12 @@ node-oracledb `v6.0.1 <https://github.com/oracle/node-oracledb/compare/v6.0.0...
 #)  Added clear error message when an attempt is made to establish a connection
     with an unsupported database version in Thin mode.
 
+#)  The buffer and process modules are now imported consistently instead of
+    relying on global variable definitions, as suggested by Sławomir Osoba in
+    `GitHub pull request #1559
+    <https://github.com/oracle/node-oracledb/pull/1559>`__.
+
+
 node-oracledb `v6.0.0 <https://github.com/oracle/node-oracledb/compare/v5.5.0...v6.0.0>`__ (24 May 2023)
 --------------------------------------------------------------------------------------------------------
 

lib/aqDeqOptions.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2019, 2022, Oracle and/or its affiliates.
+// Copyright (c) 2019, 2023, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //
@@ -26,6 +26,7 @@
 
 'use strict';
 
+const { Buffer } = require('buffer');
 const constants = require('./constants.js');
 const errors = require('./errors.js');
 

lib/aqQueue.js

@@ -26,6 +26,7 @@
 
 'use strict';
 
+const { Buffer } = require('buffer');
 const constants = require('./constants.js');
 const errors = require('./errors.js');
 const nodbUtil = require('./util.js');

lib/connection.js

@@ -28,6 +28,7 @@
 
 const AqQueue = require('./aqQueue.js');
 const BaseDbObject = require('./dbObject.js');
+const { Buffer } = require('buffer');
 const Lob = require('./lob.js');
 const ResultSet = require('./resultset.js');
 const SodaDatabase = require('./sodaDatabase.js');
@@ -36,6 +37,7 @@ const QueryStream = require('./queryStream.js');
 const errors = require('./errors.js');
 const nodbUtil = require('./util.js');
 const impl = require('./impl');
+const process = require('process');
 const util = require('util');
 const constants = require('./constants.js');
 const settings = require('./settings.js');

lib/lob.js

@@ -26,6 +26,7 @@
 
 'use strict';
 
+const { Buffer } = require('buffer');
 const { Duplex } = require('stream');
 const constants = require('./constants.js');
 const errors = require('./errors.js');

lib/oracledb.js

@@ -31,6 +31,7 @@ const nodbUtil = require('./util.js');
 const errors = require('./errors.js');
 const types = require('./types.js');
 const impl = require('./impl');
+const process = require('process');
 const util = require('util');
 
 // This version of node-oracledb works with Node.js 14.6 or later.
@@ -68,7 +69,6 @@ const defaultPoolAlias = 'default';
 let _initOracleClientArgs;
 let _thinDriverInitialized = false;
 
-
 // Load the Oracledb binary
 function _initCLib() {
   /*global __non_webpack_require__*/  // quieten eslint

lib/poolStatistics.js

@@ -26,6 +26,7 @@
 
 'use strict';
 
+const process = require('process');
 const settings = require('./settings.js');
 
 //-----------------------------------------------------------------------------

lib/queryStream.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2015, 2022, Oracle and/or its affiliates.
+// Copyright (c) 2015, 2023, Oracle and/or its affiliates.
 
 //-----------------------------------------------------------------------------
 //
@@ -26,6 +26,7 @@
 
 'use strict';
 
+const process = require('process');
 const { Readable } = require('stream');
 
 class QueryStream extends Readable {

lib/sodaDatabase.js

@@ -26,6 +26,7 @@
 
 'use strict';
 
+const { Buffer } = require('buffer');
 const SodaCollection = require('./sodaCollection.js');
 const SodaDocument = require('./sodaDocument.js');
 const errors = require('./errors.js');

lib/thin/connection.js

@@ -26,6 +26,7 @@
 
 'use strict';
 
+const { Buffer } = require('buffer');
 const ConnectionImpl = require('../impl/connection.js');
 const ThinResultSetImpl = require('./resultSet.js');
 const ThinLobImpl  = require("./lob.js");
@@ -36,6 +37,7 @@ const { Statement } = require("./statement");
 const thinUtil = require('./util');
 const sqlNetConstants = require('./sqlnet/constants.js');
 const constants = require('./protocol/constants.js');
+const process = require('process');
 const types = require('../types.js');
 const errors = require("../errors.js");
 const messages = require('./protocol/messages');