Commit 589614e
committed
Address review feedback from @paxiaatucsdedu
- Fix mypy settings: revert warn_unused_ignores to true (match langchain-google standards)
- Remove unnecessary type: ignore comments (4 total across oci_generative_ai.py and oci_data_science.py)
- Remove duplicate test file test_openai_model.py (consolidated into test_openai_models.py)
- Update PR description to clarify Python 3.9 backwards compatibility via conditional dependencies1 parent 915c40a commit 589614e
File tree
4 files changed
+5
-83
lines changed- libs/oci
- langchain_oci/chat_models
- tests/integration_tests/chat_models
4 files changed
+5
-83
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
780 | 780 | | |
781 | 781 | | |
782 | 782 | | |
783 | | - | |
| 783 | + | |
784 | 784 | | |
785 | 785 | | |
786 | 786 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1287 | 1287 | | |
1288 | 1288 | | |
1289 | 1289 | | |
1290 | | - | |
| 1290 | + | |
1291 | 1291 | | |
1292 | 1292 | | |
1293 | 1293 | | |
| |||
1360 | 1360 | | |
1361 | 1361 | | |
1362 | 1362 | | |
1363 | | - | |
| 1363 | + | |
1364 | 1364 | | |
1365 | 1365 | | |
1366 | 1366 | | |
| |||
1384 | 1384 | | |
1385 | 1385 | | |
1386 | 1386 | | |
1387 | | - | |
| 1387 | + | |
1388 | 1388 | | |
1389 | 1389 | | |
1390 | 1390 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
Lines changed: 0 additions & 78 deletions
This file was deleted.
0 commit comments