Skip to content

Commit bf16dc0

Browse files
committed
[GR-23341] Make test_tempfile pass.
PullRequest: graalpython/1694
2 parents e9dc1d3 + db0931c commit bf16dc0

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_tempfile.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_choose_directory
2121
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_collision_with_existing_directory
2222
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_collision_with_existing_file
23+
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_mode
2324
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_non_directory
2425
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_nonexisting_directory
2526
*graalpython.lib-python.3.test.test_tempfile.TestMkdtemp.test_read_only_directory
@@ -55,6 +56,7 @@
5556
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_context_manager_after_rollover
5657
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_context_manager_before_rollover
5758
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_context_manager_during_rollover
59+
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_del_on_close
5860
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_fileno
5961
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_multiple_close_after_rollover
6062
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_multiple_close_before_rollover
@@ -63,6 +65,7 @@
6365
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_sparse
6466
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_text_mode
6567
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_text_newline_and_encoding
68+
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_truncate_with_size_parameter
6669
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_write_sequential
6770
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_writelines
6871
*graalpython.lib-python.3.test.test_tempfile.TestSpooledTemporaryFile.test_writelines_sequential
@@ -76,7 +79,9 @@
7679
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryDirectory.test_mkdtemp_failure
7780
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryDirectory.test_modes
7881
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryDirectory.test_multiple_close
82+
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryDirectory.test_warnings_on_cleanup
7983
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryFile.test_basic
84+
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryFile.test_has_no_name
8085
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryFile.test_mode_and_encoding
8186
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryFile.test_multiple_close
8287
*graalpython.lib-python.3.test.test_tempfile.TestTemporaryFile.test_no_leak_fd

graalpython/lib-python/3/test/test_tempfile.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
import unittest
1717
from test import support
18-
from test.support import script_helper
18+
from test.support import script_helper, impl_detail
1919

2020

2121
has_textmode = (tempfile._text_openflags != tempfile._bin_openflags)
@@ -1446,6 +1446,7 @@ def generator():
14461446
self.assertNotIn("Exception ", err)
14471447
self.assertIn("ResourceWarning: Implicitly cleaning up", err)
14481448

1449+
@impl_detail("finalization", graalvm=False)
14491450
def test_warnings_on_cleanup(self):
14501451
# ResourceWarning will be triggered by __del__
14511452
with self.do_create() as dir:

0 commit comments

Comments
 (0)