refactor(db): internalize pool initialization within getConnection

getConnection now handles pool creation internally, eliminating the need for external init calls.

Author: JuanVillegas95

templates/app/utils/db/index.cjs

@@ -4,6 +4,8 @@
 ** All rights reserved
 ** Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 */
+
+// app/server/utils/db/config.cjs
 const oracledb = require('oracledb');
 const dbConfig = require('./config.cjs');
 
@@ -15,24 +17,24 @@ class DBConnector {
         this.pool = null;
     }
 
-    async init() {
-        try {
-            this.pool = await oracledb.createPool({
-                ...dbConfig,
-                poolMax: 10,
-                poolMin: 10
-            });
-            console.log('Connection pool created successfully.');
-        } catch (error) {
-            console.error('Error creating connection pool:', error);
-            throw error;
+    async createPool() {
+        if (!this.pool) {
+            try {
+                this.pool = await oracledb.createPool({
+                    ...dbConfig,
+                    poolMax: 10,
+                    poolMin: 10
+                });
+                console.log('Connection pool created successfully.');
+            } catch (error) {
+                console.error('Error creating connection pool:', error);
+                throw error;
+            }
         }
     }
 
     async getConnection(options = {}) {
-        if (!this.pool) {
-            throw new Error('Connection pool not initialized.');
-        }
+        await this.createPool();
         try {
             const connection = await this.pool.getConnection({
                 ...dbConfig,
@@ -46,4 +48,4 @@ class DBConnector {
     }
 }
 
-module.exports = new DBConnector();
+module.exports = new DBConnector();

templates/app/utils/rest-services/connection.cjs

@@ -4,15 +4,15 @@
 ** All rights reserved
 ** Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 */
-const db = require( '../db/index.cjs' );
+
+const db = require('../db/index.cjs');
 
 exports.getStatus = async function () {
-    await db.init();
     const connection = await db.getConnection();
-    const result = await connection.execute( 'select 1 from dual' );
+    const result = await connection.execute('select 1 from dual');
     await connection.close();
 
     return {
         status: 'ok',
-    }
-};
+    };
+};