From fa9a3bf881a05ad7c20cf175c633e0fac28a9d5e Mon Sep 17 00:00:00 2001 From: Immanuel Date: Sat, 1 Oct 2022 00:06:09 +0200 Subject: [PATCH] fix: avoid deprecation notices when passing null to strlen (#253) Co-authored-by: Mirza Sohail Hussain --- src/Optimizely/DecisionService/DecisionService.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Optimizely/DecisionService/DecisionService.php b/src/Optimizely/DecisionService/DecisionService.php index 34f86db6..cb8f6bd6 100644 --- a/src/Optimizely/DecisionService/DecisionService.php +++ b/src/Optimizely/DecisionService/DecisionService.php @@ -510,7 +510,7 @@ public function getForcedVariation(ProjectConfigInterface $projectConfig, $exper $experimentId = $projectConfig->getExperimentFromKey($experimentKey)->getId(); // check for null and empty string experiment ID - if (strlen($experimentId) == 0) { + if (strlen((string)$experimentId) == 0) { // this case is logged in getExperimentFromKey return [ null, $decideReasons]; } @@ -554,7 +554,7 @@ public function setForcedVariation(ProjectConfigInterface $projectConfig, $exper $experimentId = $experiment->getId(); // check if the experiment exists in the datafile (a new experiment is returned if it is not in the datafile) - if (strlen($experimentId) == 0) { + if (strlen((string)$experimentId) == 0) { // this case is logged in getExperimentFromKey return false; } @@ -570,7 +570,7 @@ public function setForcedVariation(ProjectConfigInterface $projectConfig, $exper $variationId = $variation->getId(); // check if the variation exists in the datafile (a new variation is returned if it is not in the datafile) - if (strlen($variationId) == 0) { + if (strlen((string)$variationId) == 0) { // this case is logged in getVariationFromKey return false; }