Skip to content

Commit 8e220c5

Browse files
oakbanimikeproeng37
authored andcommitted
Convert http_build_query to json_encode (#94)
1 parent 451dc1c commit 8e220c5

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/Optimizely/Optimizely.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ protected function sendImpressionEvent($experimentKey, $variationKey, $userId, $
239239
sprintf(
240240
'Dispatching impression event to URL %s with params %s.',
241241
$impressionEvent->getUrl(),
242-
http_build_query($impressionEvent->getParams())
242+
json_encode($impressionEvent->getParams())
243243
)
244244
);
245245

@@ -356,7 +356,7 @@ public function track($eventKey, $userId, $attributes = null, $eventTags = null)
356356
sprintf(
357357
'Dispatching conversion event to URL %s with params %s.',
358358
$conversionEvent->getUrl(),
359-
http_build_query($conversionEvent->getParams())
359+
json_encode($conversionEvent->getParams())
360360
)
361361
);
362362

tests/OptimizelyTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,7 @@ public function testTrackNoAttributesNoEventValue()
890890
->method('log')
891891
->with(
892892
Logger::DEBUG,
893-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
893+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
894894
);
895895

896896
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
@@ -1028,7 +1028,7 @@ public function testTrackNoAttributesNoEventValueAfterSetForcedVariation()
10281028
->method('log')
10291029
->with(
10301030
Logger::DEBUG,
1031-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
1031+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
10321032
);
10331033

10341034
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
@@ -1168,7 +1168,7 @@ public function testTrackWithAttributesNoEventValue()
11681168
->method('log')
11691169
->with(
11701170
Logger::DEBUG,
1171-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
1171+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
11721172
);
11731173

11741174
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
@@ -1304,7 +1304,7 @@ public function testTrackNoAttributesWithDeprecatedEventValue()
13041304
->method('log')
13051305
->with(
13061306
Logger::DEBUG,
1307-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
1307+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
13081308
);
13091309

13101310
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
@@ -1430,7 +1430,7 @@ public function testTrackNoAttributesWithEventValue()
14301430
->method('log')
14311431
->with(
14321432
Logger::DEBUG,
1433-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
1433+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
14341434
);
14351435

14361436
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
@@ -1525,7 +1525,7 @@ public function testTrackNoAttributesWithInvalidEventValue()
15251525
->with(Logger::INFO, 'Tracking event "purchase" for user "test_user".');
15261526
$this->loggerMock->expects($this->at($callIndex++))
15271527
->method('log')
1528-
->with(Logger::DEBUG, 'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.');
1528+
->with(Logger::DEBUG, 'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.');
15291529

15301530
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
15311531

@@ -1669,7 +1669,7 @@ public function testTrackWithAttributesWithDeprecatedEventValue()
16691669
->method('log')
16701670
->with(
16711671
Logger::DEBUG,
1672-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
1672+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
16731673
);
16741674

16751675

@@ -1809,7 +1809,7 @@ public function testTrackWithAttributesWithEventValue()
18091809
->method('log')
18101810
->with(
18111811
Logger::DEBUG,
1812-
'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.'
1812+
'Dispatching conversion event to URL logx.optimizely.com/track with params {"param1":"val1"}.'
18131813
);
18141814

18151815
$optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
@@ -3094,7 +3094,7 @@ public function testSendImpressionEventWithNoAttributes()
30943094
->method('log')
30953095
->with(
30963096
Logger::DEBUG,
3097-
'Dispatching impression event to URL logx.optimizely.com/decision with params param1=val1&param2=val2.'
3097+
'Dispatching impression event to URL logx.optimizely.com/decision with params {"param1":"val1","param2":"val2"}.'
30983098
);
30993099

31003100
$optlyObject->sendImpressionEvent('group_experiment_1', 'group_exp_1_var_2', 'user_1', null);
@@ -3173,7 +3173,7 @@ public function testSendImpressionEventWithAttributes()
31733173
->method('log')
31743174
->with(
31753175
Logger::DEBUG,
3176-
'Dispatching impression event to URL logx.optimizely.com/decision with params param1=val1.'
3176+
'Dispatching impression event to URL logx.optimizely.com/decision with params {"param1":"val1"}.'
31773177
);
31783178

31793179
$eventBuilder = new \ReflectionProperty(Optimizely::class, '_eventBuilder');

0 commit comments

Comments
 (0)