Preserve volume spec items

Otherwise things like read_only, sub_path, etc are dropped from the final spec.

Author: psolomin

kubeluigi/k8s.py

@@ -92,10 +92,11 @@ def get_container_with_volume_mounts(container):
     """
     volumes_spec = container["volume_mounts"]
     mount_volumes = []
+    keys_to_omit = {"host_path"}
     for volume in volumes_spec:
-        mount_path = volume["mountPath"]
-        name = volume["name"]
-        mount_volumes.append(V1VolumeMount(mount_path=mount_path, name=name))
+        # we need things like read_only, sub_path, etc:
+        volume_std_spec = {k: v for k, v in volume.items() if k not in keys_to_omit}
+        mount_volumes.append(V1VolumeMount(**volume_std_spec))
     container["volume_mounts"] = mount_volumes
     return container
 

test/kubernetes_helpers_test.py

@@ -56,7 +56,7 @@ def test_pod_spec_from_dict():
             "imagePullPolicy": "Always",
             "env": [{"name": "my_env", "value": "env"}],
             "volume_mounts": [
-                {"name": "Vname", "mountPath": "VmountPath", "host_path": "VhostPath"}
+                {"name": "Vname", "mount_path": "VmountPath", "host_path": "VhostPath"}
             ],
         }
     ],
@@ -105,7 +105,7 @@ def test_pod_spec_with_volume_from_dict():
     "imagePullPolicy": "Always",
     "env": [{"name": "my_env", "value": "env"}],
     "volume_mounts": [
-        {"name": "Vname", "mountPath": "VmountPath", "host_path": "VhostPath"}
+        {"name": "Vname", "mount_path": "VmountPath", "host_path": "VhostPath"}
     ],
 }