Skip to content

Commit 5b0039b

Browse files
mfahadahmedmikeproeng37
authored andcommitted
chore(contrib): Add PR template and commit message guidelines. (#111)
1 parent 2fef96f commit 5b0039b

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

CONTRIBUTING.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@ We welcome contributions and feedback! All contributors must sign our [Contribut
33

44
## Development process
55

6-
1. Create a branch off of `master`: `git checkout -b YOUR_NAME/branch_name`.
7-
2. Commit your changes. Make sure to add tests!
8-
3. `git push` your changes to GitHub.
9-
4. Make sure that all unit tests are passing and that there are no merge conflicts between your branch and `master`.
10-
5. Open a pull request from `YOUR_NAME/branch_name` to `master`.
11-
6. A repository maintainer will review your pull request and, if all goes well, merge it!
6+
1. Fork the repository and create your branch from master.
7+
2. Please follow the [commit message guidelines](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines) for each commit message.
8+
3. Make sure to add tests!
9+
4. `git push` your changes to GitHub.
10+
5. Open a PR from your fork into the master branch of the original repo.
11+
6. Make sure that all unit tests are passing and that there are no merge conflicts between your branch and `master`.
12+
7. Open a pull request from `YOUR_NAME/branch_name` to `master`.
13+
8. A repository maintainer will review your pull request and, if all goes well, squash and merge it!
1214

1315
## Pull request acceptance criteria
1416

pull_request_template.md

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
## Summary
2+
- The "what"; a concise description of each logical change
3+
- Another change
4+
5+
The "why", or other context.
6+
7+
## Test plan
8+
9+
## Issues
10+
- "THING-1234" or "Fixes #123"

0 commit comments

Comments
 (0)