Skip to content

Commit 502f2d1

Browse files
committed
fixes on impl
1 parent b2c6915 commit 502f2d1

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

operator-framework/src/main/java/io/javaoperatorsdk/operator/api/UpdateControl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ public static <T extends CustomResource> UpdateControl<T> updateStatusSubResourc
3131
* As a results of this there will be two call to K8S API. First the custom resource will be
3232
* updates then the status sub-resource.
3333
*/
34-
public static <T extends CustomResource>
35-
UpdateControl<T> updateCustomResourceAndStatus(T customResource) {
34+
public static <T extends CustomResource> UpdateControl<T> updateCustomResourceAndStatus(
35+
T customResource) {
3636
return new UpdateControl<>(customResource, true, true);
3737
}
3838

operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/EventDispatcher.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,12 @@ private PostExecutionControl handleCreateOrUpdate(
105105
CustomResource updatedCustomResource = null;
106106
if (updateControl.isUpdateCustomResourceAndStatusSubResource()) {
107107
updatedCustomResource = updateCustomResource(updateControl.getCustomResource());
108-
updatedCustomResource = customResourceFacade.updateStatus(updatedCustomResource);
108+
updateControl
109+
.getCustomResource()
110+
.getMetadata()
111+
.setResourceVersion(updatedCustomResource.getMetadata().getResourceVersion());
112+
updatedCustomResource =
113+
customResourceFacade.updateStatus(updateControl.getCustomResource());
109114
} else if (updateControl.isUpdateStatusSubResource()) {
110115
updatedCustomResource =
111116
customResourceFacade.updateStatus(updateControl.getCustomResource());

operator-framework/src/test/java/io/javaoperatorsdk/operator/UpdatingResAndSubResIT.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.javaoperatorsdk.operator.doubleupdate.subresource.DoubleUpdateTestCustomResourceController;
1414
import io.javaoperatorsdk.operator.doubleupdate.subresource.DoubleUpdateTestCustomResourceSpec;
1515
import io.javaoperatorsdk.operator.doubleupdate.subresource.DoubleUpdateTestCustomResourceStatus;
16-
import io.javaoperatorsdk.operator.sample.subresource.SubResourceTestCustomResourceStatus;
1716
import java.util.concurrent.TimeUnit;
1817
import org.junit.jupiter.api.BeforeEach;
1918
import org.junit.jupiter.api.Test;
@@ -41,13 +40,13 @@ public void updatesSubResourceStatus() {
4140

4241
awaitStatusUpdated(resource.getMetadata().getName());
4342
// wait for sure, there are no more events
44-
waitXms(200);
43+
waitXms(300);
4544

4645
DoubleUpdateTestCustomResource customResource =
4746
(DoubleUpdateTestCustomResource)
4847
integrationTestSupport.getCustomResource(resource.getMetadata().getName());
4948
assertThat(integrationTestSupport.numberOfControllerExecutions()).isEqualTo(1);
50-
assertThat(customResource.getStatus())
49+
assertThat(customResource.getStatus().getState())
5150
.isEqualTo(DoubleUpdateTestCustomResourceStatus.State.SUCCESS);
5251
assertThat(customResource.getMetadata().getAnnotations().get(TEST_ANNOTATION))
5352
.isNotNull();
@@ -70,7 +69,7 @@ void awaitStatusUpdated(String name) {
7069
assertThat(cr).isNotNull();
7170
assertThat(cr.getStatus()).isNotNull();
7271
assertThat(cr.getStatus().getState())
73-
.isEqualTo(SubResourceTestCustomResourceStatus.State.SUCCESS);
72+
.isEqualTo(DoubleUpdateTestCustomResourceStatus.State.SUCCESS);
7473
});
7574
}
7675

operator-framework/src/test/java/io/javaoperatorsdk/operator/doubleupdate/subresource/DoubleUpdateTestCustomResourceController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import io.javaoperatorsdk.operator.TestExecutionInfoProvider;
44
import io.javaoperatorsdk.operator.api.*;
5-
65
import java.util.HashMap;
76
import java.util.concurrent.atomic.AtomicInteger;
87
import org.slf4j.Logger;

0 commit comments

Comments
 (0)