Skip to content

Commit 051bd5a

Browse files
committed
test improvements
1 parent bd6de40 commit 051bd5a

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

operator-framework/src/test/java/com/github/containersolutions/operator/EventSchedulerTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ public void notGenerationAwareSchedulingProcessesAllEventsRegardlessOfGeneration
105105
.matches(list -> eventProcessingList.get(0).getCustomResource().getMetadata().getResourceVersion().equals("1") &&
106106
eventProcessingList.get(1).getCustomResource().getMetadata().getResourceVersion().equals("2"),
107107
"Events processed in correct order")
108-
.matches(list ->
109-
eventProcessingList.get(0).getEndTime().isBefore(eventProcessingList.get(1).startTime),
108+
.matches(list -> eventExecutedBefore(0, 1),
110109
"Start time of event 2 is after end time of event 1");
111110
}
112111

@@ -132,8 +131,7 @@ public void onlyLastEventIsScheduledIfMoreReceivedDuringAndExecution() {
132131
.matches(list -> eventProcessingList.get(0).getCustomResource().getMetadata().getResourceVersion().equals("1") &&
133132
eventProcessingList.get(1).getCustomResource().getMetadata().getResourceVersion().equals("3"),
134133
"Events processed in correct order")
135-
.matches(list ->
136-
eventProcessingList.get(0).getEndTime().isBefore(eventProcessingList.get(1).startTime),
134+
.matches(list -> eventExecutedBefore(0, 1),
137135
"Start time of event 2 is after end time of event 1");
138136
}
139137

@@ -175,8 +173,7 @@ public void processesNewEventIfItIsReceivedAfterExecutionInError() {
175173
.matches(list -> eventProcessingList.get(0).getCustomResource().getMetadata().getResourceVersion().equals("1") &&
176174
eventProcessingList.get(1).getCustomResource().getMetadata().getResourceVersion().equals("2"),
177175
"Events processed in correct order")
178-
.matches(list ->
179-
eventProcessingList.get(0).getEndTime().isBefore(eventProcessingList.get(1).startTime),
176+
.matches(list -> eventExecutedBefore(0, 1),
180177
"Start time of event 2 is after end time of event 1");
181178

182179
assertThat(eventProcessingList.get(0).getException()).isNotNull();
@@ -233,6 +230,11 @@ private Object exceptionInExecution(InvocationOnMock invocation) {
233230
}
234231
}
235232

233+
private boolean eventExecutedBefore(int event1Index, int event2Index) {
234+
return eventProcessingList.get(event1Index).getEndTime().isBefore(eventProcessingList.get(event2Index).startTime) ||
235+
eventProcessingList.get(event1Index).getEndTime().equals(eventProcessingList.get(event2Index).startTime);
236+
}
237+
236238
private void waitMinimalTimeForExecution() {
237239
waitTimeForExecution(1);
238240
}

0 commit comments

Comments
 (0)