refactor(csv): don't use pointers for rawmessage fields

Prevents fields of type *json.RawMessage from causing controller-gen to
output bad deepcopy types by switching to json.RawMessage. The
underlying type is []byte, so the fields remain semantically equivalent.

Author: njhale

pkg/operators/clusterserviceversion_types.go

@@ -77,7 +77,7 @@ type StatusDescriptor struct {
 	DisplayName  string
 	Description  string
 	XDescriptors []string
-	Value        *json.RawMessage
+	Value        json.RawMessage
 }
 
 // SpecDescriptor describes a field in a spec block of a CRD so that OLM can consume it
@@ -86,7 +86,7 @@ type SpecDescriptor struct {
 	DisplayName  string
 	Description  string
 	XDescriptors []string
-	Value        *json.RawMessage
+	Value        json.RawMessage
 }
 
 // ActionDescriptor describes a declarative action that can be performed on a custom resource instance
@@ -95,7 +95,7 @@ type ActionDescriptor struct {
 	DisplayName  string
 	Description  string
 	XDescriptors []string
-	Value        *json.RawMessage
+	Value        json.RawMessage
 }
 
 // CRDDescription provides details to OLM about the CRDs

pkg/operators/v1alpha1/clusterserviceversion_types.go

@@ -77,31 +77,31 @@ func (d *StrategyDetailsDeployment) GetStrategyName() string {
 // StatusDescriptor describes a field in a status block of a CRD so that OLM can consume it
 // +k8s:openapi-gen=true
 type StatusDescriptor struct {
-	Path         string           `json:"path"`
-	DisplayName  string           `json:"displayName,omitempty"`
-	Description  string           `json:"description,omitempty"`
-	XDescriptors []string         `json:"x-descriptors,omitempty"`
-	Value        *json.RawMessage `json:"value,omitempty"`
+	Path         string          `json:"path"`
+	DisplayName  string          `json:"displayName,omitempty"`
+	Description  string          `json:"description,omitempty"`
+	XDescriptors []string        `json:"x-descriptors,omitempty"`
+	Value        json.RawMessage `json:"value,omitempty"`
 }
 
 // SpecDescriptor describes a field in a spec block of a CRD so that OLM can consume it
 // +k8s:openapi-gen=true
 type SpecDescriptor struct {
-	Path         string           `json:"path"`
-	DisplayName  string           `json:"displayName,omitempty"`
-	Description  string           `json:"description,omitempty"`
-	XDescriptors []string         `json:"x-descriptors,omitempty"`
-	Value        *json.RawMessage `json:"value,omitempty"`
+	Path         string          `json:"path"`
+	DisplayName  string          `json:"displayName,omitempty"`
+	Description  string          `json:"description,omitempty"`
+	XDescriptors []string        `json:"x-descriptors,omitempty"`
+	Value        json.RawMessage `json:"value,omitempty"`
 }
 
 // ActionDescriptor describes a declarative action that can be performed on a custom resource instance
 // +k8s:openapi-gen=true
 type ActionDescriptor struct {
-	Path         string           `json:"path"`
-	DisplayName  string           `json:"displayName,omitempty"`
-	Description  string           `json:"description,omitempty"`
-	XDescriptors []string         `json:"x-descriptors,omitempty"`
-	Value        *json.RawMessage `json:"value,omitempty"`
+	Path         string          `json:"path"`
+	DisplayName  string          `json:"displayName,omitempty"`
+	Description  string          `json:"description,omitempty"`
+	XDescriptors []string        `json:"x-descriptors,omitempty"`
+	Value        json.RawMessage `json:"value,omitempty"`
 }
 
 // CRDDescription provides details to OLM about the CRDs