cleanup

Author: aryanA101a

tests/conftest.py

@@ -125,11 +125,6 @@ def valid_user_agent():
     return "name/version (contact)"
 
 
-@pytest.fixture(scope="module")
-def invalid_user_agent():
-    return "name version) (contact)"
-
-
 @pytest.fixture(scope="session")
 def small_zim_file(tmpdir_factory):
     from zimscraperlib.download import stream_file

tests/inputs/test_inputs.py

@@ -91,7 +91,7 @@ def mock_stream_file(**kwargs):
         assert headers is not None
         user_agent = headers.get("User-Agent")
         assert isinstance(user_agent, str)
-        assert user_agent.startswith(PROJECT_NAME)
+        assert user_agent.startswith(f"{PROJECT_NAME}/")
         assert user_agent.endswith(f"({CONTACT})")
 
     monkeypatch.setattr(
@@ -103,6 +103,23 @@ def mock_stream_file(**kwargs):
     handle_user_provided_file(source=valid_http_url)
 
 
+def test_remote_provided_user_agent(valid_http_url, valid_user_agent, monkeypatch):
+    def mock_stream_file(**kwargs):
+        headers = kwargs.get("headers")
+        assert headers is not None
+        user_agent = headers.get("User-Agent")
+        assert isinstance(user_agent, str)
+        assert user_agent == valid_user_agent
+
+    monkeypatch.setattr(
+        zimscraperlib.inputs,  # pyright: ignore[reportAttributeAccessIssue]
+        "stream_file",
+        mock_stream_file,
+        raising=True,
+    )
+    handle_user_provided_file(source=valid_http_url, user_agent=valid_user_agent)
+
+
 def test_remote_provided_none_user_agent(valid_http_url, monkeypatch):
     def mock_stream_file(**kwargs):
         assert kwargs.get("headers") is None