Skip to content

Commit f10f2ca

Browse files
committed
using a variable for recomended max title length
1 parent d72a132 commit f10f2ca

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/zimscraperlib/constants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
),
4949
}
5050

51+
RECOMMENDED_MAX_TITLE_LENGTH = 30
5152
MAXIMUM_DESCRIPTION_METADATA_LENGTH = 80
5253
MAXIMUM_LONG_DESCRIPTION_METADATA_LENGTH = 4000
5354

src/zimscraperlib/zim/metadata.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
MANDATORY_ZIM_METADATA_KEYS,
99
MAXIMUM_DESCRIPTION_METADATA_LENGTH,
1010
MAXIMUM_LONG_DESCRIPTION_METADATA_LENGTH,
11+
RECOMMENDED_MAX_TITLE_LENGTH,
1112
)
1213
from ..i18n import is_valid_iso_639_3
1314
from ..image.probing import is_valid_image
@@ -40,7 +41,7 @@ def validate_standard_str_types(name: str, value: str):
4041

4142
def validate_title(name: str, value: str):
4243
"""ensures Title metadata is within recommended length"""
43-
if name == "Title" and len(value) > 30:
44+
if name == "Title" and len(value) > RECOMMENDED_MAX_TITLE_LENGTH:
4445
raise ValueError(f"{name} is too long.")
4546

4647

0 commit comments

Comments
 (0)