fix: fix memory leaks of RAF callbacks.

andycall · andycall · commit 3ebc8dc82395 · 2023-12-28T08:46:30.000Z
diff --git a/bridge/core/dom/scripted_animation_controller.cc b/bridge/core/dom/scripted_animation_controller.cc
@@ -23,8 +23,10 @@ static void handleRAFTransientCallback(void* ptr, double contextId, double highR
     return;
   }
 
-  if (frame_callback->status() == FrameCallback::FrameStatus::kCanceled)
+  if (frame_callback->status() == FrameCallback::FrameStatus::kCanceled) {
+    context->document()->script_animations()->callbackCollection()->RemoveFrameCallback(frame_callback->frameId());
     return;
+  }
 
   assert(frame_callback->status() == FrameCallback::FrameStatus::kPending);
 

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,10 @@ static void handleRAFTransientCallback(void* ptr, double contextId, double highR`
`23`	`23`	`return;`
`24`	`24`	`}`
`25`	`25`
`26`		`- if (frame_callback->status() == FrameCallback::FrameStatus::kCanceled)`
	`26`	`+ if (frame_callback->status() == FrameCallback::FrameStatus::kCanceled) {`
	`27`	`+ context->document()->script_animations()->callbackCollection()->RemoveFrameCallback(frame_callback->frameId());`
`27`	`28`	`return;`
	`29`	`+ }`
`28`	`30`
`29`	`31`	`assert(frame_callback->status() == FrameCallback::FrameStatus::kPending);`
`30`	`32`