Skip to content

Commit 18a35cc

Browse files
author
david
committed
feat: support ScopedPersistent<v8::Context>
1 parent 07b7cbd commit 18a35cc

11 files changed

+56
-408
lines changed

bridge/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,6 @@ elseif ($ENV{WEBF_JS_ENGINE} MATCHES "v8")
433433
bindings/v8/wrapper_type_info.cc
434434
bindings/v8/v8_interface_bridge_base.cc
435435
bindings/v8/v8_initializer.cc
436-
# bindings/v8/platform/script_state.cc
437436
bindings/v8/platform/scoped_persistent.h
438437
bindings/v8/platform/v8_per_context_data.cc
439438
bindings/v8/platform/v8_per_isolate_data.cc

bridge/bindings/v8/platform/scoped_persistent.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class ScopedPersistent {
2828

2929
~ScopedPersistent() { Clear(); }
3030

31-
ALWAYS_INLINE v8::Local<T> NewLocal(v8::Isolate* isolate) const {
31+
inline v8::Local<T> NewLocal(v8::Isolate* isolate) const {
3232
return v8::Local<T>::New(isolate, handle_);
3333
}
3434

@@ -66,7 +66,7 @@ class ScopedPersistent {
6666
return handle_ == other;
6767
}
6868

69-
ALWAYS_INLINE v8::Persistent<T>& Get() { return handle_; }
69+
inline v8::Persistent<T>& Get() { return handle_; }
7070

7171
private:
7272
v8::Persistent<T> handle_;

bridge/bindings/v8/platform/script_state.cc

-87
This file was deleted.

0 commit comments

Comments
 (0)