Skip to content

Add configuration to display narrative distances in metric units #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
binh-dam-ibigroup opened this issue Apr 27, 2020 · 2 comments
Open

Add configuration to display narrative distances in metric units #158

binh-dam-ibigroup opened this issue Apr 27, 2020 · 2 comments

Comments

@binh-dam-ibigroup
Copy link
Collaborator

This issues originates from this suggestion to add a config parameter to display narrative distances in metric units. Currently, distances are hard-coded to be shown as imperial.

This issue depends on otpui/#116.
@binh-dam-ibigroup binh-dam-ibigroup mentioned this issue Apr 27, 2020
Merged
@amenk amenk mentioned this issue Feb 4, 2023
Closed
amenk added a commit to AddisMap/AddisMapTransit-web that referenced this issue Feb 4, 2023
@amenk
opentripplanner#158 Add config option to display metrix units
57393af
amenk added a commit to AddisMap/AddisMapTransit-web that referenced this issue Feb 4, 2023
@amenk
opentripplanner#158 Add config option to display metrix units
af3973c
amenk added a commit to AddisMap/AddisMapTransit-web that referenced this issue Feb 4, 2023
@amenk
opentripplanner#158 Add config option to display metrix units
c41c2bd
@nukeador
Copy link
Contributor

Just checking on this. Since I see there is a path on one of the forks, is this something you are interested in integrating here?

@nukeador
Copy link
Contributor

I think this keeps being blocked by this pending PR for otp-ui to fix @opentripplanner/itinerary-body

opentripplanner/otp-ui#736

Also at otp-react-redux level, lib/components/viewers/nearby/distance-display.tsx has hard-coded imperial units here

localizedDistanceString: humanizeDistanceString(distance, false, intl)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nukeador @binh-dam-ibigroup