Merge pull request #1407 from opentripplanner/remove-stop-id-when-no-stop-code

remove stop id from nearby view side panel

Author: miles-grant-ibigroup

__tests__/components/viewers/__snapshots__/nearby-view.js.snap

@@ -18425,17 +18425,6 @@ exports[`components > viewers > nearby view renders proper scooter dates 1`] = `
                                     className="sc-hJxDiT gGpYuf"
                                   >
                                     <div>
-                                      <FormattedMessage
-                                        id="components.StopViewer.displayStopId"
-                                        values={
-                                          Object {
-                                            "stopId": "40:990003",
-                                            "strong": [Function],
-                                          }
-                                        }
-                                      >
-                                        components.StopViewer.displayStopId
-                                      </FormattedMessage>
                                       <Styled(Connect(Component))
                                         className="stop-header-action"
                                         to="/schedule/40:990003"
@@ -47000,17 +46989,6 @@ exports[`components > viewers > nearby view renders proper scooter dates 1`] = `
                                     className="sc-hJxDiT gGpYuf"
                                   >
                                     <div>
-                                      <FormattedMessage
-                                        id="components.StopViewer.displayStopId"
-                                        values={
-                                          Object {
-                                            "stopId": "40:990004",
-                                            "strong": [Function],
-                                          }
-                                        }
-                                      >
-                                        components.StopViewer.displayStopId
-                                      </FormattedMessage>
                                       <Styled(Connect(Component))
                                         className="stop-header-action"
                                         to="/schedule/40:990004"

lib/components/viewers/nearby/stop-card-header.tsx

@@ -60,13 +60,15 @@ const StopCardHeader = ({
       </CardHeader>
       <CardBody>
         <div>
-          <FormattedMessage
-            id="components.StopViewer.displayStopId"
-            values={{
-              stopId: stopData.code || stopData.gtfsId,
-              strong: Strong
-            }}
-          />
+          {stopData.code ? (
+            <FormattedMessage
+              id="components.StopViewer.displayStopId"
+              values={{
+                stopId: stopData.code,
+                strong: Strong
+              }}
+            />
+          ) : null}
           {onZoomClick ? (
             <button
               className="link-button"