[CCE]fix k8s_tags and taints are not removable #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
CCE API is only removing/clearing
taintsandk8s_tagsif they get a defined empty list/map:Currently there is no way to clear these from the API once they are defined. You can overwrite them with dummy values, which is kinda OK for kubernetes labels, but not for taints. If any taint is left on the node/nodepool you have to:
a) tolerate that taint in all your deployments(even in ds)
b) go to the console and delete manually
I have tested these changes with the terraform provider and now it does remove
taintsandk8s_tagsif they become undefined. (note:k8s_tagsalso needcomputed: falsefor this behavior)At this point this is just a proposal, I dont understand the sdk and the provider well enough to know if this would break anything else.
Which issue this PR fixes
Special notes for your reviewer