Skip to content

Commit 4a12e25

Browse files
authored
fix: ServerConfig cannot be found when the component is unmounted (#236)
1 parent bff6397 commit 4a12e25

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

packages/sumi-core/src/server/logs-core/log-manager.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ import { DEFAULT_LOG_FOLDER, LogService } from './log.service';
1414
@Injectable()
1515
export class LogServiceManager implements ILogServiceManager {
1616
@Autowired(ServerConfig)
17-
private serverConfig: ServerConfig;
17+
// 卸载时会有时序问题导致 serverConfig 被销毁,这边改为 Optional
18+
private serverConfig?: ServerConfig;
1819

1920
protected readonly logLevelChangeEmitter = new Emitter<LogLevel>();
2021
private globalLogLevel: LogLevel;
@@ -25,8 +26,8 @@ export class LogServiceManager implements ILogServiceManager {
2526

2627
constructor() {
2728
this.init({
28-
logDir: this.serverConfig.logDir,
29-
logLevel: this.serverConfig.logLevel,
29+
logDir: this.serverConfig?.logDir,
30+
logLevel: this.serverConfig?.logLevel,
3031
});
3132
this.cleanOldLogs();
3233
}
@@ -35,7 +36,7 @@ export class LogServiceManager implements ILogServiceManager {
3536
this.logRootFolderPath = options.logDir || DEFAULT_LOG_FOLDER;
3637
this.logFolderPath = this._getLogFolder();
3738
this.globalLogLevel = options.logLevel || LogLevel.Info;
38-
this.LogServiceClass = this.serverConfig.LogServiceClass || LogService;
39+
this.LogServiceClass = this.serverConfig?.LogServiceClass || LogService;
3940
};
4041

4142
getLogger = (

0 commit comments

Comments
 (0)