Skip to content

OCPBUGS-59258: 🐛 add catalog-operator control-plane-specific tolerations to unpack jobs #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

grokspawn
Copy link
Contributor

  • add catalog-operator control-plane-specific tolerations to unpack jobs
  • refactored common in test

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 57e6b8c8b381be1d6432718905b9825495836470

…obs (#3606)

* add catalog-operator control-plane-specific tolerations to unpack jobs

Signed-off-by: grokspawn <[email protected]>

* refactored common in test

Signed-off-by: grokspawn <[email protected]>

---------

Signed-off-by: grokspawn <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 57e6b8c8b381be1d6432718905b9825495836470
Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@grokspawn
Copy link
Contributor Author

/jira cherrypick OCPBUGS-58349

@openshift-ci-robot
Copy link

@grokspawn: Jira Issue OCPBUGS-58349 has been cloned as Jira Issue OCPBUGS-59258. Will retitle bug to link to clone.
/retitle OCPBUGS-59258: 🐛 add catalog-operator control-plane-specific tolerations to unpack jobs

In response to this:

/jira cherrypick OCPBUGS-58349

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title 🐛 add catalog-operator control-plane-specific tolerations to unpack jobs OCPBUGS-59258: 🐛 add catalog-operator control-plane-specific tolerations to unpack jobs Jul 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 11, 2025
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-59258, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-58349 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-58349 to target a version in 4.20.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • add catalog-operator control-plane-specific tolerations to unpack jobs
  • refactored common in test

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 57e6b8c8b381be1d6432718905b9825495836470

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@grokspawn
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-59258, which is invalid:

  • expected dependent Jira Issue OCPBUGS-58349 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-58349 to target a version in 4.20.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 11, 2025

@grokspawn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 81f63f7 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grokspawn
Copy link
Contributor Author

/retest-required

@grokspawn
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 16, 2025
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-59258, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-58349 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-58349 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oceanc80
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 16, 2025
@Xia-Zhao-rh
Copy link

Xia-Zhao-rh commented Jul 16, 2025

/label qe-approved

Test PASS, detail https://issues.redhat.com/browse/OCPBUGS-59258

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 16, 2025
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-59258, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-58349 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-58349 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

  • add catalog-operator control-plane-specific tolerations to unpack jobs
  • refactored common in test

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 57e6b8c8b381be1d6432718905b9825495836470

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh July 16, 2025 06:53
@Xia-Zhao-rh
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8bcf155 into openshift:release-4.19 Jul 16, 2025
13 of 14 checks passed
@openshift-ci-robot
Copy link

@grokspawn: Jira Issue OCPBUGS-59258: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59258 has been moved to the MODIFIED state.

In response to this:

  • add catalog-operator control-plane-specific tolerations to unpack jobs
  • refactored common in test

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 57e6b8c8b381be1d6432718905b9825495836470

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.19.0-202507160907.p0.g8bcf155.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.19.0-202507160907.p0.g8bcf155.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.19.0-202507160907.p0.g8bcf155.assembly.stream.el9.
All builds following this will include this PR.

@grokspawn grokspawn deleted the tolerations-4.19 branch July 16, 2025 20:19
@grokspawn
Copy link
Contributor Author

/jira cherry-pick release-4.18

@grokspawn
Copy link
Contributor Author

/jira backport release-4.18

@grokspawn
Copy link
Contributor Author

/cherrypick release-4.18

@openshift-cherrypick-robot

@grokspawn: new pull request created: #1040

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-07-16-160211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.