pkg/cli/admin/upgrade/recommend: Add a blank line after --version conditional risk

When I added the:

  Update to 4.18.6 Recommended=False:
  ...

block in c1ef328 (pkg/cli/admin/upgrade/recommend: Add --version
option for specific releases, 2024-10-14, #1897), there was no
subsequent output in this "--version has conditional risks" case, so
the earlier lack-of-blank-line made sense.

But then 2d7e004 (pkg/cli/admin/upgrade/recommend: New,
feature-gated --accept, 2025-05-06, #2023) gave the option for a
subsequent:

  error: issues that apply to this cluster but which were not included in --accept: ...

or:

  Update to %s has no known issues relevant...

This commit adds a new line to standard output, to offset those
summaries from the possibly-long Message:

  ...
  Update to 4.18.6 Recommended=False:
  Image: quay.io/openshift-release-dev/ocp-release@sha256:61fdad894f035a8b192647c224faf565279518255bdbf60a91db4ee0479adaa6
  Release URL: https://access.redhat.com/errata/RHSA-2025:3066
  Reason: CRIOLayerCompressionPulls
  Message: The CRI-O container runtime may fail to pull images with certain layer compression characteristics https://issues.redhat.com/browse/OCPNODE-3074

  error: issues that apply to this cluster but which were not included in --accept: ConditionalUpdateRisk,KubeContainerWaiting

instead of cramming that 'error: ...' or '... has no known issues...'
right onto the end of the output.  Although the error is getting
written to standard error instead of the standard output, so in that
case, the newline will only matter for terminal users and others who
are flattening those two streams together.

And now that we have the additional newline handling in recommend.go,
I can drop the newline I'd been manually injecting in examples_test.go
to make the test fixtures more readable.  I should have noticed that
test-specific injection as a sign that the better recommend.go newline
handling was useful.  Oh well, better late than never.

Author: wking

pkg/cli/admin/upgrade/recommend/examples_test.go

@@ -97,7 +97,7 @@ func TestExamples(t *testing.T) {
 				opts.ErrOut = &stderr
 
 				if err := opts.Run(context.Background()); err != nil {
-					compareWithFixture(t, bytes.Join([][]byte{stdout.Bytes(), []byte("\nerror: "), []byte(err.Error()), []byte("\n")}, []byte{}), cv, variant.outputSuffix)
+					compareWithFixture(t, bytes.Join([][]byte{stdout.Bytes(), []byte("error: "), []byte(err.Error()), []byte("\n")}, []byte{}), cv, variant.outputSuffix)
 				} else {
 					compareWithFixture(t, stdout.Bytes(), cv, variant.outputSuffix)
 				}

pkg/cli/admin/upgrade/recommend/recommend.go

@@ -343,9 +343,12 @@ func (o *options) Run(ctx context.Context) error {
 					}
 					unaccepted := issues.Difference(accept)
 					if unaccepted.Len() > 0 {
+						if !o.quiet {
+							fmt.Fprintln(o.Out)
+						}
 						return fmt.Errorf("issues that apply to this cluster but which were not included in --accept: %s", strings.Join(sets.List(unaccepted), ","))
 					} else if issues.Len() > 0 && !o.quiet {
-						fmt.Fprintf(o.Out, "Update to %s has no known issues relevant to this cluster other than the accepted %s.\n", update.Release.Version, strings.Join(sets.List(issues), ","))
+						fmt.Fprintf(o.Out, "\nUpdate to %s has no known issues relevant to this cluster other than the accepted %s.\n", update.Release.Version, strings.Join(sets.List(issues), ","))
 					}
 					return nil
 				}