Baremetal image filenames require additional validation

[hardys]

Since #2757 landed it's possible to specify arbitrary filenames in the install config, for locally mirrored rhcos images.

However we rely on the installer generated filename currently, to replace -openstack with -compressed - this aligns with how the downloader container works, and fails if the filename doesn't match the expected format:

https://github.com/openshift/installer/blob/master/pkg/asset/machines/baremetal/machines.go#L88

openshift/ironic-rhcos-downloader#21

To reproduce you can specify e.g:

clusterOSImage: http://1.2.3.4/rhcos.qcow2.gz?sha256=xyz

instead of the expected e.g:

clusterOSImage: http://1.2.3.4/rhcos-44.81.202001030903.0-openstack.x86_64.qcow2.gz?sha256=xyz

The installer will accept this, but the downloader container will fail, and the providerSpec image reference will be wrong.

We need to either add validation to catch this, or rework the string substitution to work with arbitrary filenames.

[hardys]

/label platform/baremetal

[imain]

Hmm.. I'd like to undo the mess with all the substitutions but that's a lot of changes throughout the stack. You have an opinion on this Steve? I'm kinda leaning toward validation for now? Be kind of a strange error message though: "ERROR: Your image name must have '-openstack' in it somewhere" :)

[imain]

I'm joking above but.. it would be a strange thing to verify.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hardys]

/reopen

[openshift-ci-robot]

@hardys: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.