refactor validation and add ratcheting validation

Author: patrickdillon

config/v1/tests/infrastructures.config.openshift.io/AAA_ungated.yaml

@@ -1985,4 +1985,48 @@ tests:
           platformStatus:
             type: AWS
             aws: {}
-      expectedStatusError: "status.platformStatus.aws: Invalid value: \"object\": resourceTags may only be configured during installation"
+      expectedStatusError: "status.platformStatus.aws: Invalid value: \"object\": resourceTags may only be configured during installation"
+    - name: Ratcheting validation for AWS prefix ResourceTags should not break updates
+      initialCRDPatches:
+      - op: remove
+        path: /spec/versions/0/schema/openAPIV3Schema/properties/status/properties/platformStatus/properties/aws/properties/resourceTags/items/properties/key/x-kubernetes-validations
+      initial: |
+        apiVersion: config.openshift.io/v1
+        kind: Infrastructure
+        spec: {}
+        status:
+          platform: AWS
+          platformStatus:
+            type: AWS
+            aws:
+              resourceTags:
+                - {key: "aws:invalidKey", value: "value"}
+      updated: |
+        apiVersion: config.openshift.io/v1
+        kind: Infrastructure
+        spec: {}
+        status:
+          platform: AWS
+          platformStatus:
+            type: AWS
+            aws:
+              resourceTags:
+                - {key: "aws:invalidKey", value: "value"}
+              serviceEndpoints:
+                - {name: "newendpoint", url: "https://www.awsendpoint.com"}
+      expected: |
+        apiVersion: config.openshift.io/v1
+        kind: Infrastructure
+        spec: {}
+        status:
+          platform: AWS
+          controlPlaneTopology: HighlyAvailable
+          cpuPartitioning: None
+          infrastructureTopology: HighlyAvailable
+          platformStatus:
+            type: AWS
+            aws:
+              resourceTags:
+                - {key: "aws:invalidKey", value: "value"}
+              serviceEndpoints:
+                - {name: "newendpoint", url: "https://www.awsendpoint.com"}

config/v1/types_infrastructure.go

@@ -503,7 +503,7 @@ type AWSPlatformSpec struct {
 }
 
 // AWSPlatformStatus holds the current status of the Amazon Web Services infrastructure provider.
-// +kubebuilder:validation:XValidation:rule="!has(oldSelf.resourceTags) && !has(self.resourceTags) || has(oldSelf.resourceTags) && has(self.resourceTags)",message="resourceTags may only be configured during installation"
+// +kubebuilder:validation:XValidation:rule="has(oldSelf.resourceTags) == has(self.resourceTags)",message="resourceTags may only be configured during installation"
 type AWSPlatformStatus struct {
 	// region holds the default AWS region for new AWS resources created by the cluster.
 	Region string `json:"region"`