Skip to content

Commit 545c745

Browse files
danbevlance
authored andcommitted
doc: use oscf/js-runtime in running locally (#20)
* doc: use oscf/js-runtime in running locally This commit uses the image name built by the make build target, instead of redhat-faas/js-runtime. It also removes the cidfile as this can be confusing to new users as unless the manually delete this file there will be an error the next time it is run: docker: Container ID file found, make sure the other container isn't running or delete my-faas-test.cid.
1 parent 31d24a5 commit 545c745

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ TEST_IMAGE = $(IMAGE_NAME):candidate
88

99
build:
1010
docker build -t $(DOCKER_IMAGE) .
11+
docker tag $(IMAGE_NAME):$(IMAGE_TAG) $(TEST_IMAGE)
1112
# docker build -t $(QUAY_IMAGE) .
1213

1314
test:

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,13 @@ to contain the runtime source code. To mount this into a running container
5151
execute the following command.
5252

5353
```sh
54-
docker run --rm --cidfile my-faas-test.cid -a stdout -a stderr -v /path/to/local/source/dir:/home/node/usr -p 8080:8080 redhat-faas/js-runtime &
54+
docker run --rm -a stdout -a stderr -v /path/to/local/source/dir:/home/node/usr -p 8080:8080 oscf/js-runtime:candidate
55+
```
56+
57+
To stop the running container:
58+
```sh
59+
$ docker ps
60+
$ docker stop <CONTAINER ID>
5561
```
5662

5763
## Testing

0 commit comments

Comments
 (0)