Add setting to be able to disable webRTC view

Author: matteius

CMakeLists.txt

@@ -38,6 +38,11 @@ if(CMAKE_BUILD_TYPE MATCHES "^[Dd][Ee][Bb][Uu][Gg]$")
         message(STATUS "Enabling AddressSanitizer and UndefinedBehaviorSanitizer for Debug build")
         add_compile_options(-fsanitize=address,undefined)
         add_link_options(-fsanitize=address,undefined)
+        add_compile_options(-ggdb3)
+
+        # improved debugging experience
+        add_compile_options(-fno-omit-frame-pointer -fno-optimize-sibling-calls)
+        add_compile_options(-fno-inline -fno-inline-functions)
     else()
         message(STATUS "Compiler (${CMAKE_C_COMPILER_ID}/${CMAKE_CXX_COMPILER_ID}) does not support sanitizers or build type is not Debug, skipping sanitizer flags.")
     endif()

include/core/config.h

@@ -84,6 +84,7 @@ typedef struct {
     bool web_auth_enabled;
     char web_username[32];
     char web_password[32]; // Stored as hash in actual implementation
+    bool webrtc_disabled;  // Whether WebRTC is disabled (use HLS only)
 
     // Web optimization settings
     bool web_compression_enabled;    // Whether to enable gzip compression for text-based responses
@@ -214,4 +215,11 @@ const char* get_loaded_config_path(void);
 // Global configuration variable
 extern config_t g_config;
 
+/**
+ * Get a pointer to the global streaming configuration
+ * 
+ * @return Pointer to the global configuration
+ */
+config_t* get_streaming_config(void);
+
 #endif /* LIGHTNVR_CONFIG_H */

src/core/config.c

@@ -50,6 +50,7 @@ void load_default_config(config_t *config) {
     config->web_auth_enabled = true;
     snprintf(config->web_username, 32, "admin");
     snprintf(config->web_password, 32, "admin"); // Default password, should be changed
+    config->webrtc_disabled = false; // WebRTC is enabled by default
 
     // Web optimization settings
     config->web_compression_enabled = true;
@@ -306,6 +307,8 @@ static int config_ini_handler(void* user, const char* section, const char* name,
             strncpy(config->web_username, value, 31);
         } else if (strcmp(name, "password") == 0) {
             strncpy(config->web_password, value, 31);
+        } else if (strcmp(name, "webrtc_disabled") == 0) {
+            config->webrtc_disabled = (strcmp(value, "true") == 0 || strcmp(value, "1") == 0);
         }
     }
     // Stream settings
@@ -850,6 +853,7 @@ int save_config(const config_t *config, const char *path) {
     fprintf(file, "auth_enabled = %s\n", config->web_auth_enabled ? "true" : "false");
     fprintf(file, "username = %s\n", config->web_username);
     fprintf(file, "password = %s  ; IMPORTANT: Change this default password!\n", config->web_password);
+    fprintf(file, "webrtc_disabled = %s\n", config->webrtc_disabled ? "true" : "false");
     fprintf(file, "\n");
 
     // Write stream settings
@@ -946,6 +950,7 @@ void print_config(const config_t *config) {
     printf("    Web Auth Enabled: %s\n", config->web_auth_enabled ? "true" : "false");
     printf("    Web Username: %s\n", config->web_username);
     printf("    Web Password: %s\n", "********");
+    printf("    WebRTC Disabled: %s\n", config->webrtc_disabled ? "true" : "false");
 
     printf("  Stream Settings:\n");
     printf("    Max Streams: %d\n", config->max_streams);

src/web/api_handlers_settings.c

@@ -37,6 +37,7 @@ void mg_handle_get_settings(struct mg_connection *c, struct mg_http_message *hm)
     cJSON_AddStringToObject(settings, "web_root", g_config.web_root);
     cJSON_AddBoolToObject(settings, "web_auth_enabled", g_config.web_auth_enabled);
     cJSON_AddStringToObject(settings, "web_username", g_config.web_username);
+    cJSON_AddBoolToObject(settings, "webrtc_disabled", g_config.webrtc_disabled);
 
     // Don't include the password for security reasons
     cJSON_AddStringToObject(settings, "web_password", "********");
@@ -135,6 +136,14 @@ void mg_handle_post_settings(struct mg_connection *c, struct mg_http_message *hm
         log_info("Updated web_password");
     }
 
+    // WebRTC disabled
+    cJSON *webrtc_disabled = cJSON_GetObjectItem(settings, "webrtc_disabled");
+    if (webrtc_disabled && cJSON_IsBool(webrtc_disabled)) {
+        g_config.webrtc_disabled = cJSON_IsTrue(webrtc_disabled);
+        settings_changed = true;
+        log_info("Updated webrtc_disabled: %s", g_config.webrtc_disabled ? "true" : "false");
+    }
+    
     // Storage path
     cJSON *storage_path = cJSON_GetObjectItem(settings, "storage_path");
     if (storage_path && cJSON_IsString(storage_path)) {

src/web/mongoose_server_static.c

@@ -73,7 +73,8 @@ void mongoose_server_handle_static_file(struct mg_connection *c, struct mg_http_
     // Special case for HLS streaming files
     if (strncmp(uri, "/hls/", 5) == 0) {
         // This is an HLS streaming request, serve it directly from the filesystem
-        config_t *global_config = get_streaming_config();
+        // Use the global configuration variable directly
+        config_t *global_config = &g_config;
 
         // Check for authentication
         log_info("Processing HLS request: %s", uri);
@@ -223,9 +224,33 @@ void mongoose_server_handle_static_file(struct mg_connection *c, struct mg_http_
         }
     }
 
-    // Special handling for root path
-    if (strcmp(uri, "/") == 0) {
-        // Directly serve index.html for root path
+    // Special handling for root path or index.html
+    if (strcmp(uri, "/") == 0 || strcmp(uri, "/index.html") == 0) {
+        // Check if WebRTC is disabled in the configuration
+        config_t *global_config = &g_config;
+        if (global_config->webrtc_disabled) {
+            // WebRTC is disabled, serve hls.html directly
+            log_info("WebRTC is disabled, serving hls.html instead of index.html");
+            
+            // Use hls.html path instead
+            char index_path[MAX_PATH_LENGTH * 2];
+            snprintf(index_path, sizeof(index_path), "%s/hls.html", server->config.web_root);
+            
+            // Log the path we're trying to serve
+            log_info("Serving hls.html: %s", index_path);
+            
+            // Use Mongoose's built-in file serving capabilities
+            struct mg_http_serve_opts opts = {
+                .root_dir = server->config.web_root,
+                .mime_types = "html=text/html",
+                .extra_headers = "Connection: close\r\n"
+            };
+            
+            mg_http_serve_file(c, hm, index_path, &opts);
+            return;
+        }
+        
+        // WebRTC is enabled, serve index.html as normal
         char index_path[MAX_PATH_LENGTH * 2];
 
         // Add debug logging to help diagnose the issue
@@ -491,7 +516,29 @@ void mongoose_server_handle_static_file(struct mg_connection *c, struct mg_http_
             }
         }
 
-        // For SPA routes, directly serve index.html without redirection
+        // Check if WebRTC is disabled in the configuration
+        config_t *global_config = &g_config;
+        if (global_config->webrtc_disabled) {
+            // WebRTC is disabled, redirect to hls.html
+            log_info("WebRTC is disabled, redirecting SPA route to hls.html");
+            
+            // Extract query string if present
+            char redirect_url[MAX_PATH_LENGTH * 2] = "/hls.html";
+            if (hm->query.len > 0) {
+                strncat(redirect_url, "?", sizeof(redirect_url) - strlen(redirect_url) - 1);
+                size_t remaining_space = sizeof(redirect_url) - strlen(redirect_url) - 1;
+                size_t copy_len = (hm->query.len < remaining_space) ? hm->query.len : remaining_space;
+                strncat(redirect_url, hm->query.buf, copy_len);
+            }
+            
+            mg_printf(c, "HTTP/1.1 302 Found\r\n");
+            mg_printf(c, "Location: %s\r\n", redirect_url);
+            mg_printf(c, "Content-Length: 0\r\n");
+            mg_printf(c, "\r\n");
+            return;
+        }
+        
+        // WebRTC is enabled, serve index.html as normal
         char index_path[MAX_PATH_LENGTH * 2];
         snprintf(index_path, sizeof(index_path), "%s/index.html", server->config.web_root);