StringIndexOutOfBoundsException while using rewrite-gradle-plugin

[man85]

I have a Kotlin project managed by Gradle.
build.gradle.kts:

plugins {
   kotlin("jvm") apply false
   id("org.openrewrite.rewrite") version "7.0.4"
}

rewrite {
   activeRecipe("com.yourorg.ChangePluginVersionExample")
}

rewrite.yml:

---
type: specs.openrewrite.org/v1beta/recipe
name: com.yourorg.ChangePluginVersionExample
displayName: Change a Gradle plugin version by id example
recipeList:
  - org.openrewrite.gradle.plugins.ChangePluginVersion:
      pluginIdPattern: net.razvan.jacoco-to-cobertura
      newVersion: 1.3.2
      versionPattern: '-jre'

When I run gradle rewriteRun --stacktrace I get an error:

Caused by: java.lang.StringIndexOutOfBoundsException: Range [1, 0) out of bounds for length 0
        at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
        at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
        at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
        at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
        at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
        at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckFromToIndex(Preconditions.java:112)
        at java.base/jdk.internal.util.Preconditions.checkFromToIndex(Preconditions.java:349)
        at org.openrewrite.java.marker.JavaSourceSet.gavFromPath(JavaSourceSet.java:243)
        at org.openrewrite.java.marker.JavaSourceSet.build(JavaSourceSet.java:206)
        at org.openrewrite.gradle.isolated.DefaultProjectParser.parseGradleProjectSourceSets(DefaultProjectParser.java:891)
        at org.openrewrite.gradle.isolated.DefaultProjectParser.parse(DefaultProjectParser.java:689)
        ... 125 more

I suppose the reason is here

@jkschneider @sambsnyd

[MBoegers]

Hi @man85 👋 , could you share a little more of your build.gradle.kts? What I am looking for is the plugin definition of net.razvan.jacoco-to-cobertura to easily create a reproducing test.

[shanman190]

The most likely suspect is that one of the subprojects of the Gradle project itself ends with "repository" and then JavaSourceSet gets tripped up since the dependency points to a local jar (repository/build/libs/repository-<version>.jar) of that project's build.

[greg-at-moderne]

If so, that would make it related or similar to #4470.

[man85]

definition of net.razvan.jacoco-to-cobertura to easily create a reproducing test.

There is no definition of net.razvan.jacoco-to-cobertura in a current project. It is transitively added by other plugin to the project. Can Openrewrite handle this situation: changing the version of a transitive plugin?

[man85]

one of the subprojects of the Gradle project itself ends with "repository"

You are absolutely right ) One of the subprojects is named repository

[shanman190]

Can Openrewrite handle this situation: changing the version of a transitive plugin?

The way that this works for Gradle -- which is not OpenRewrite specific -- is by either changing the dependency version found in buildscript or changing the version via declaring the plugin as a first-order plugin. Gradle additionally supports changing the version by resolution rules within the settings.gradle script.

As far as OpenRewrite goes, the easiest way to alter the version would be with the AddBuildPlugin recipe to add the specified plugin as a first order plugin dependency.