Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScanningRecipes that don't add/modify/delete files should report the estimated time savings other than zero #4909

Open
bmuschko opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@bmuschko
Copy link
Contributor

bmuschko commented Jan 15, 2025

What version of OpenRewrite are you using?

  • Moderne Sass v10.181.0

How are you running OpenRewrite?

From the Sass UI.

What is the smallest, simplest way to reproduce the problem?

Run the recipe org.openrewrite.FindGitProvenance against one or many repositories. I am only using this recipe as an example in this case to demonstrate the issue. Say, I'd write a custom ScanningRecipe that only generates files but doesn't change any, I think I would see the same issue.

What did you expect to see?

The "Estimated time savings" on the "Summary" tab should report a higher number than 0. Every recipe sets 5 minutes as the default for the estimated savings. Given that a ScanningRecipe doesn't override the method, I'd expect the same behavior.

Maybe this is expected behavior but it is not clearly documented as of now. Maybe you can clarify.

What did you see instead?

The "Estimated time savings" on the "Summary" tab should reports 0 even though the data tables produced by the recipe have been populated. Work has been done even though no files were changed.

image
@bmuschko bmuschko added the bug Something isn't working label Jan 15, 2025
@timtebeek timtebeek moved this to Backlog in OpenRewrite Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant