Also replace Logger.log(Level.CONFIG, ..)

openrewrite · Jun 15, 2024 · b181035 · b181035
1 parent 45a53b4
commit b181035
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/src/main/java/org/openrewrite/java/logging/jul/LoggerLevelArgumentToMethod.java b/src/main/java/org/openrewrite/java/logging/jul/LoggerLevelArgumentToMethod.java
@@ -220,4 +220,36 @@ void after(Logger logger, Supplier<String> message) {
             logger.severe(message);
         }
     }
+
+    @RecipeDescriptor(
+            name = "Replace JUL `Logger.log(Level.CONFIG, String)` with `Logger.config(String)`",
+            description = "Replace calls to `java.util.logging.Logger.log(Level.CONFIG, String)` with `Logger.config(String)`."
+    )
+    public static class LogLevelConfigToMethod {
+        @BeforeTemplate
+        void before(Logger logger, String message) {
+            logger.log(Level.CONFIG, message);
+        }
+
+        @AfterTemplate
+        void after(Logger logger, String message) {
+            logger.config(message);
+        }
+    }
+
+    @RecipeDescriptor(
+            name = "Replace JUL `Logger.log(Level.CONFIG, Supplier<String>)` with `Logger.config(Supplier<String>)`",
+            description = "Replace calls to `java.util.logging.Logger.log(Level.CONFIG, Supplier<String>)` with `Logger.config(Supplier<String>)`."
+    )
+    public static class LogLevelConfigSupplierToMethod {
+        @BeforeTemplate
+        void before(Logger logger, Supplier<String> message) {
+            logger.log(Level.CONFIG, message);
+        }
+
+        @AfterTemplate
+        void after(Logger logger, Supplier<String> message) {
+            logger.config(message);
+        }
+    }
 }
diff --git a/src/test/java/org/openrewrite/java/logging/jul/LoggerLevelArgumentToMethodTest.java b/src/test/java/org/openrewrite/java/logging/jul/LoggerLevelArgumentToMethodTest.java
@@ -47,6 +47,7 @@ void test(Logger logger, String message) {
                       logger.log(Level.INFO, message);
                       logger.log(Level.WARNING, message);
                       logger.log(Level.SEVERE, message);
+                      logger.log(Level.CONFIG, message);
                   }
               }
               """,
@@ -61,6 +62,7 @@ void test(Logger logger, String message) {
                       logger.info(message);
                       logger.warning(message);
                       logger.severe(message);
+                      logger.config(message);
                   }
               }
               """
@@ -86,6 +88,7 @@ void test(Logger logger, Supplier<String> message) {
                       logger.log(Level.INFO, message);
                       logger.log(Level.WARNING, message);
                       logger.log(Level.SEVERE, message);
+                      logger.log(Level.CONFIG, message);
                   }
               }
               """,
@@ -101,6 +104,7 @@ void test(Logger logger, Supplier<String> message) {
                       logger.info(message);
                       logger.warning(message);
                       logger.severe(message);
+                      logger.config(message);
                   }
               }
               """
@@ -120,7 +124,6 @@ void noReplacementMethod() {
               class Test {
                   void test(Logger logger, String message) {
                       logger.log(Level.ALL, message);
-                      logger.log(Level.CONFIG, message);
                       logger.log(Level.OFF, message);
                   }
               }