Merge pull request #711 from Csantucci/fix-precipitation-out-of-bounds

Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs

Author: twpol

Source/RunActivity/Viewer3D/Precipitation.cs

@@ -446,6 +446,19 @@ public float GetHeight(WorldLocation location, TileManager tiles, SceneryDrawer
                 var x = (int)((location.Location.X + 1024) / BlockSize);
                 var z = (int)((location.Location.Z + 1024) / BlockSize);
 
+                // Trace the case where x or z are out of bounds and fix
+                var xSize = tile.Height.GetLength(0);
+                var zSize = tile.Height.GetLength(1);
+                if (x < 0 || x >= xSize || z < 0 || z >= zSize)
+                {
+                    Trace.TraceWarning("At least one precipitation index is out of bounds:  x = {0}, z = {1}, Location.X = {2}, Location.Z = {3}, BlockSize = {4}, HeightDimensionX = {5}, HeightDimensionZ = {6} ; fixing it",
+                        x, z, location.Location.X, location.Location.Z, BlockSize, xSize, zSize);
+                    if (x >= xSize) x = xSize - 1;
+                    if (z >= zSize) z = zSize - 1;
+                    if (x < 0) x = 0;
+                    if (z < 0) z = 0;
+                }
+
                 // If we don't have it cached, load it.
                 if (tile.Height[x, z] == float.MinValue)
                 {