refactor: simplify boolean logic (distributive law + complement law)

YoRyan · YoRyan · commit e63df9811f10 · 2021-07-15T11:16:23.000-07:00
diff --git a/Source/Orts.Simulation/Simulation/Signalling/Signals.cs b/Source/Orts.Simulation/Simulation/Signalling/Signals.cs
@@ -11096,8 +11096,7 @@ private void getBlockState_notRouted()
 
                     // if section has signal at end stop check
 
-                    if (thisSection.EndSignals[direction] != null
-                        || (thisSection.CircuitType == TrackCircuitSection.TrackCircuitType.EndOfTrack && thisSection.EndSignals[direction] == null))
+                    if (thisSection.EndSignals[direction] != null || thisSection.CircuitType == TrackCircuitSection.TrackCircuitType.EndOfTrack)
                     {
                         thisSection = null;
                     }

Original file line number	Diff line number	Diff line change
`@@ -11096,8 +11096,7 @@ private void getBlockState_notRouted()`
`11096`	`11096`
`11097`	`11097`	`// if section has signal at end stop check`
`11098`	`11098`
`11099`		`- if (thisSection.EndSignals[direction] != null`
`11100`		`- \|\| (thisSection.CircuitType == TrackCircuitSection.TrackCircuitType.EndOfTrack && thisSection.EndSignals[direction] == null))`
	`11099`	`+ if (thisSection.EndSignals[direction] != null \|\| thisSection.CircuitType == TrackCircuitSection.TrackCircuitType.EndOfTrack)`
`11101`	`11100`	`{`
`11102`	`11101`	`thisSection = null;`
`11103`	`11102`	`}`