File tree Expand file tree Collapse file tree 3 files changed +35
-35
lines changed Expand file tree Collapse file tree 3 files changed +35
-35
lines changed Original file line number Diff line number Diff line change @@ -55,15 +55,15 @@ All new features must result in the following three things existing:
55
55
These things must be done in the required order:
56
56
57
57
1 . The road-map card cannot be approved without the completed discussion
58
- 2 . The pull request cannot be pending (non-draft) without the completed discussion
58
+ 2 . The pull request cannot be ready for review without the completed discussion
59
59
3 . The pull request cannot be approved without the approved road-map card
60
60
61
61
Our recommended order is:
62
62
63
63
1 . Create road-map card
64
64
2 . Create forum discussion
65
65
3 . Create draft pull request
66
- 4 . When discussion is completed, pull request can be pending
66
+ 4 . When discussion is completed, pull request can be ready for review
67
67
5 . When road-map card is approved, pull request can be approved (if code review is okay)
68
68
69
69
** Note:** A blueprint can be used by a seasoned Open Rails developer in place of a road-map card.
@@ -130,7 +130,7 @@ Your code should be fixing exactly one bug or adding a single new feature; mixin
130
130
131
131
### Different versions of code
132
132
133
- When your pull request is draft or pending , it will not be included in any version of Open Rails unless:
133
+ When your pull request is draft or ready for review , it will not be included in any version of Open Rails unless:
134
134
135
135
* You are a member of the core team
136
136
* A member of the core team adds a particular label
Original file line number Diff line number Diff line change 1
1
digraph {
2
- roadmapPending [label =" Road-map (pending )" ]
2
+ roadmapCreated [label =" Road-map (created )" ]
3
3
roadmapApproved [label =" Road-map (approved)" ]
4
4
discussion [label =" Discussion (1 week)" ]
5
5
prDraft [label =" Pull request (draft)" ] [style =dashed]
6
- prPending [label =" Pull request (pending )" ]
6
+ prReadyForReview [label =" Pull request (ready for review )" ]
7
7
prApproved [label =" Pull request (approved)" ]
8
- roadmapPending -> roadmapApproved
9
- discussion -> {roadmapApproved,prPending } -> prApproved
10
- roadmapPending -> discussion -> prDraft -> prPending [style =dashed]
8
+ roadmapCreated -> roadmapApproved
9
+ discussion -> {roadmapApproved,prReadyForReview } -> prApproved
10
+ roadmapCreated -> discussion -> prDraft -> prReadyForReview [style =dashed]
11
11
}
You can’t perform that action at this time.
0 commit comments