fix: Use only standard built-in compression classes

Author: twpol

Source/Orts.Updater/Orts.Updater.csproj

@@ -16,14 +16,14 @@
     <DocumentationFile>..\..\Program\Orts.Updater.xml</DocumentationFile>
   </PropertyGroup>
   <ItemGroup>
+    <Reference Include="System.IO.Compression" />
     <Reference Include="System.Security" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\Orts.Common\Orts.Common.csproj" />
     <ProjectReference Include="..\Orts.Settings\Orts.Settings.csproj" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="DotNetZip" Version="1.16.0" />
     <PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.4.355802">
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

Source/Orts.Updater/UpdateManager.cs

@@ -15,7 +15,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Open Rails.  If not, see <http://www.gnu.org/licenses/>.
 
-using Ionic.Zip;
 using Newtonsoft.Json;
 using ORTS.Common;
 using ORTS.Settings;
@@ -24,6 +23,7 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
+using System.IO.Compression;
 using System.Linq;
 using System.Net;
 using System.Runtime.InteropServices;
@@ -413,14 +413,22 @@ void DownloadUpdate(int progressMin, int progressLength)
 
         void ExtractUpdate(int progressMin, int progressLength)
         {
-            using (var zip = ZipFile.Read(FileUpdateStage))
+            using (var zip = ZipFile.OpenRead(FileUpdateStage))
             {
-                zip.ExtractProgress += (object sender, ExtractProgressEventArgs e) =>
+                for (var index = 0; index < zip.Entries.Count; index++)
                 {
-                    if (e.EventType == ZipProgressEventType.Extracting_BeforeExtractEntry)
-                        TriggerApplyProgressChanged(progressMin + progressLength * e.EntriesExtracted / e.EntriesTotal);
-                };
-                zip.ExtractAll(PathUpdateStage, ExtractExistingFileAction.OverwriteSilently);
+                    TriggerApplyProgressChanged(progressMin + progressLength * index / zip.Entries.Count);
+
+                    var absolutePath = Path.GetFullPath(Path.Combine(PathUpdateStage, zip.Entries[index].FullName));
+                    if (!absolutePath.StartsWith(PathUpdateStage))
+                        throw new IOException("Invalid update: attempting to extract outside staging area");
+
+                    if (Path.GetFileName(absolutePath).Length > 0)
+                    {
+                        Directory.CreateDirectory(Path.GetDirectoryName(absolutePath));
+                        zip.Entries[index].ExtractToFile(absolutePath, true);
+                    }
+                }
             }
 
             File.Delete(FileUpdateStage);