Merge pull request #761 from twpol/bugfix/persistent-clouds

twpol · web-flow · commit 17af6ffa8ff8 · 2023-01-18T21:37:53.000Z
fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds
diff --git a/Source/RunActivity/Viewer3D/Shaders.cs b/Source/RunActivity/Viewer3D/Shaders.cs
@@ -384,7 +384,7 @@ public float Overcast
             set
             {
                 if (value < 0.2f)
-                    overcast.SetValue(new Vector4(4 * value + 0.2f, 0.0f, 0.0f, 0.0f));
+                    overcast.SetValue(new Vector4(5 * value, 0.0f, 0.0f, 0.0f));
                 else
                     // Coefficients selected by author to achieve the desired appearance
                     overcast.SetValue(new Vector4(MathHelper.Clamp(2 * value - 0.4f, 0, 1), 1.25f - 1.125f * value, 1.15f - 0.75f * value, 1f));

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ public float Overcast`
`384`	`384`	`set`
`385`	`385`	`{`
`386`	`386`	`if (value < 0.2f)`
`387`		`- overcast.SetValue(new Vector4(4 * value + 0.2f, 0.0f, 0.0f, 0.0f));`
	`387`	`+ overcast.SetValue(new Vector4(5 * value, 0.0f, 0.0f, 0.0f));`
`388`	`388`	`else`
`389`	`389`	`// Coefficients selected by author to achieve the desired appearance`
`390`	`390`	`overcast.SetValue(new Vector4(MathHelper.Clamp(2 * value - 0.4f, 0, 1), 1.25f - 1.125f * value, 1.15f - 0.75f * value, 1f));`