-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event detail page #56
Comments
I wonder why we need this as you can do all this via Google Calendar. |
Because Google calendar won't be able to do all the things we need it to do, like display the event in the language of the user. |
Then why are we using Google Calendar at all? If we are going to recreate its functionality in the app, there seems little reason to export the events. |
Why do you think the event detail page is recreating functionality from Google Calendar? Here's how I'm thinking of it. By publishing to Google Calendar, we are gaining all the features of Google Calendar and then layering additional functionality on top. Any tool that integrates with Google Calendar, can essentially integrate with out application (although this is only partially true without more advanced integration). For example, event approval. Google Calendar does not have a concept of creating "pending" events privately and then publishing them once approved. So that's a feature we layer on top. In order to show pending events to approvers, we need to show the full detail of the event. Even if we published pending events to a private Google Calendar, not all of those details are supported by Google Calendar, like languages. We are walking a thin line about what features should be Google Calendar vs the application. We'll know more as we go but the event detail is a quick way to move forward without betting too much on Google Calendar, which would require some complex integration work. We'll get to more advanced integration with Google Calendar, but I don't think we want to spend time on it until we understand the workflow with ACCCC. |
While I'm not sure I agree completely with your analysis. We already have the update page to show the full detail of the event to approvers, so I don't see the need for this feature to for that reason. I do think this may be a good solution for showing all the event details over #68. We can add a link to the event detail page in the Calendar description. That way the code will not need to be updated when detail fields are added/removed/changed. |
As a user, I want a page that represents a single event, so that I can link, share, and bookmark the page where I can see all the details related to the event and how to attend, also allowing me to better find it in web search results.
We also want to link back from the description in the google calendar.
Acceptance criteria
/event/:id
url exists for eventsThe text was updated successfully, but these errors were encountered: