From 4a55e4030d8d64e7253714b2c8e84a908312b9c3 Mon Sep 17 00:00:00 2001
From: Christoph Maurhofer <maurhofer@ubique.ch>
Date: Mon, 15 Jan 2024 14:39:50 +0100
Subject: [PATCH] Call glFinish on render breaks

---
 .../mapscore/graphics/GLThread.kt             | 23 ++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/android/src/main/java/io/openmobilemaps/mapscore/graphics/GLThread.kt b/android/src/main/java/io/openmobilemaps/mapscore/graphics/GLThread.kt
index 50bbddd82..c2008e38c 100644
--- a/android/src/main/java/io/openmobilemaps/mapscore/graphics/GLThread.kt
+++ b/android/src/main/java/io/openmobilemaps/mapscore/graphics/GLThread.kt
@@ -16,6 +16,7 @@ import android.util.Log
 import io.openmobilemaps.mapscore.BuildConfig
 import java.util.concurrent.ConcurrentLinkedQueue
 import java.util.concurrent.atomic.AtomicBoolean
+import java.util.concurrent.atomic.AtomicLong
 import javax.microedition.khronos.egl.*
 import javax.microedition.khronos.egl.EGLConfig
 import javax.microedition.khronos.egl.EGLContext
@@ -38,6 +39,10 @@ class GLThread constructor(
 		private const val TAG = "GLThread"
 		private const val EGL_OPENGL_ES3_BIT = 0x00000040
 
+		private const val PAUSE_RENDER_INTERVAL = 30000L
+		private const val BREAK_RENDER_INTERVAL = 1000L
+		private const val BREAK_MIN_FINISH_MS = BREAK_RENDER_INTERVAL / 2
+
 		const val MAX_NUM_GRAPHICS_PRE_TASKS = 16
 
 		private val defaultConfig = intArrayOf(
@@ -69,6 +74,8 @@ class GLThread constructor(
 	val runNotifier = Object()
 	var glRunList = ConcurrentLinkedQueue<() -> Unit>()
 	val isDirty = AtomicBoolean(false)
+	val lastDirtyTimestamp = AtomicLong(0)
+	var hasFinishedSinceDirty = false
 
 	var renderer: GLSurfaceView.Renderer? = null
 	var surface: SurfaceTexture? = null
@@ -106,12 +113,23 @@ class GLThread constructor(
 			if ((!isDirty.get() && glRunList.isEmpty()) || isPaused) {
 				var wasPaused = false
 				do {
+					var firstPause = false
 					if (isPaused && !wasPaused) {
 						onPauseCallback?.invoke()
 						wasPaused = true
+						firstPause = true
+					}
+					val preFinish = System.currentTimeMillis()
+					if (firstPause || (!hasFinishedSinceDirty && preFinish - lastDirtyTimestamp.get() > BREAK_MIN_FINISH_MS)) {
+						GLES32.glFinish()
+						hasFinishedSinceDirty = true
 					}
+					val finishDuration = System.currentTimeMillis() - preFinish
+
 					try {
-						synchronized(runNotifier) { runNotifier.wait(1000) }
+						if (finishDuration < BREAK_RENDER_INTERVAL) {
+							synchronized(runNotifier) { runNotifier.wait(if (isPaused) PAUSE_RENDER_INTERVAL else BREAK_RENDER_INTERVAL - finishDuration) }
+						}
 					} catch (e: InterruptedException) {
 						e.printStackTrace()
 					}
@@ -360,7 +378,10 @@ class GLThread constructor(
 	}
 
 	fun requestRender() {
+		lastDirtyTimestamp.set(System.currentTimeMillis())
+		hasFinishedSinceDirty = false
 		isDirty.set(true)
+
 		synchronized(runNotifier) { runNotifier.notify() }
 	}