[REVIEW]: pykoop: a Python Library for Koopman Operator Approximation

[editorialbot]

Submitting author: @sdahdah (Steven Dahdah)
Repository: https://github.com/decargroup/pykoop
Branch with paper.md (empty if default branch): paper
Version: v2.0.1
Editor: @gkthiruvathukal
Reviewers: @kramea, @matt-graham
Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5"><img src="https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5/status.svg)](https://joss.theoj.org/papers/9f06e8db0de47aa49b55596155ab3cd5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kramea & @matt-graham, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @gkthiruvathukal know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@kramea, please create your checklist typing: @editorialbot generate my checklist

@matt-graham, please create your checklist typing: @editorialbot generate my checklist

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.98  T=0.13 s (552.1 files/s, 180230.9 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                           34           1556           5402          11480
Jupyter Notebook                  8              0           2246            639
reStructuredText                  6            176            228            297
Markdown                          6             70              0            235
TeX                               2             16              0            161
YAML                              7              1              5            159
Bourne Again Shell                1             11             38             34
DOS Batch                         1              8              1             26
Text                              2              3              0             20
INI                               2              1              0             19
make                              1              4              7              9
--------------------------------------------------------------------------------
SUM:                             70           1846           7927          13079
--------------------------------------------------------------------------------

Commit count by author:

   624	Steven Dahdah
     1	James Forbes

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 615

✅ The paper includes a Statement of need section

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.21105/joss.05881 is OK
- 10.1098/rspa.2022.0162 is OK
- 10.1088/2632-2153/ad45b0 is OK
- 10.48550/arXiv.2403.10623 is OK
- 10.48550/arXiv.2410.01057 is OK
- 10.48550/arXiv.2408.16846 is OK
- 10.5281/zenodo.5576490 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python
- No DOI given, and none found for title: DLKoopman: A deep learning software package for Ko...
- No DOI given, and none found for title: Machine-Learning-Dynamical-Systems/kooplearn v1.1....

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈