-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8366441: AArch64: Support WFET in OnSpinWait #27030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Implement OnSpinWait based on WFET - wait for event with timeout: - introduce OnSpinWaitDelay - the OnSpinWait time in nanoseconds; - the OnSpinWaitInstCount is expected to be 1 when WFET is used; - the waiting loop is followed by SB - to ensure following instructions aren't speculated until wait is finished; - the timer register is read via the self-synchronized view CNTVCTSS_EL0 to prevent the read being hoisted out of the loop. The WFET and CNTVCTSS_EL0 read are added to aarch64-asmtest.py as hex values - using the instruction mnemonics would require support of -march=armv9-2.a, and consequently, the binutils 2.36+. Co-authored-by: Stuart Monteith <[email protected]>
|
👋 Welcome back ruben-arm! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@ruben-arm The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/contributor add @stooart-mon |
|
@ruben-arm |
So please use binutils 2.36+. |
|
@ruben-arm This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@ruben-arm The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@ruben-arm this pull request can not be integrated into git checkout pr-8366441
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Implement OnSpinWait based on WFET - wait for event with timeout:
The WFET and CNTVCTSS_EL0 read are added to aarch64-asmtest.py as hex values - using the instruction mnemonics would require support of -march=armv9-2.a, and consequently, the binutils 2.36+.
Progress
Issue
Contributors
<[email protected]>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27030/head:pull/27030$ git checkout pull/27030Update a local copy of the PR:
$ git checkout pull/27030$ git pull https://git.openjdk.org/jdk.git pull/27030/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27030View PR using the GUI difftool:
$ git pr show -t 27030Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27030.diff