8362379: Test serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java should mark as /native

[sendaoYan]

Hi all,

Test serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java call native libary 'UnmountedVThreadNativeMethodAtTop' with System.loadLibrary. If run this test without jtreg option '-nativepath', jtreg will report 'JUnit test failure'. After this PR, we add jtreg directive /native to test header, run this test without jtreg option '-nativepath', jtreg will report 'Error. Use -nativepath to specify the location of native code'. So add /native directive will make this test more friendly.

Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362379: Test serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java should mark as /native (Enhancement - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26384/head:pull/26384
$ git checkout pull/26384

Update a local copy of the PR:
$ git checkout pull/26384
$ git pull https://git.openjdk.org/jdk.git pull/26384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26384

View PR using the GUI difftool:
$ git pr show -t 26384

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26384.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362379: Test serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java should mark as /native

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 60c29ff: 8362524: Fix confusing but harmless typos in x86 CPU Features
• 30d2003: 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1
• 9dc6282: 8362169: Pointer passed to upcall may get wrong scope
• ... and 2 more: https://git.openjdk.org/jdk/compare/4e0b03580d3764e06ec65493143e80c291fa3fbb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8efbea31)

[sspitsyn]

Looks good.

[sendaoYan]

Thanks for the reviews @sspitsyn @plummercj

/integrate

[openjdk]

Going to push as commit ee0bcc5.
Since your change was applied there have been 10 commits pushed to the master branch:

• ceb51d4: 8362829: Exclude CDS test cases after JDK-8361725
• d83346d: 8345836: Stable annotation documentation is incomplete
• 9334fe2: 8361725: Do not load Java agent with "-Xshare:dump -XX:+AOTClassLinking"
• ... and 7 more: https://git.openjdk.org/jdk/compare/4e0b03580d3764e06ec65493143e80c291fa3fbb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit ee0bcc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.