Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour when multiple is used with transaction data #462

Open
TimoGlastra opened this issue Mar 18, 2025 · 4 comments
Open

Behaviour when multiple is used with transaction data #462

TimoGlastra opened this issue Mar 18, 2025 · 4 comments
Milestone

Comments

@TimoGlastra
Copy link
Member

When the new multiple query field from DCQL is used, what is the intended behaviour for transaction data?

Should all credentials include the transaction data hash, or only the first one? I think a small clarification on intended behaviour might help.

I could find anything in the spec or #398

@c2bo
Copy link
Member

c2bo commented Mar 19, 2025

Imho multiple and transaction_data should be mutually exclusive. multiple has some level of ambiguity to it by design, whereas transaction_data should only be used when you know exactly what credential you want.

@Sakurann
Copy link
Collaborator

Sakurann commented Mar 20, 2025

+1 to what Christian said

(sorry, did not mean to close)

@Sakurann Sakurann reopened this Mar 20, 2025
@TimoGlastra
Copy link
Member Author

Makes sense, we should probably add something to spec for that? It would make the implementation simpler by not having to deal with it

@c2bo
Copy link
Member

c2bo commented Mar 20, 2025

Yeah, We should add a sentence that transaction_data MUST NOT be used in combination with multiple. I can do a quick PR fixing that if people are fine with a PR clarifying in that direction.

@Sakurann Sakurann added this to the 1.1 milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants