Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid privacy manifest #883

Closed
zz-0io opened this issue Oct 8, 2024 · 17 comments
Closed

Invalid privacy manifest #883

zz-0io opened this issue Oct 8, 2024 · 17 comments
Labels
bug triage Issues that need to be triaged

Comments

@zz-0io
Copy link

zz-0io commented Oct 8, 2024

Describe the bug
The Privacyinfo.xcprivacy file from the following path is invalid:"Frameworks/AppAuth.framework/AppAuthExternalUserAgent Privacy.bundle/Privacyinfo.xcprivacy". in addition the privacy manifest files in the locations outlined in the documentation, starting November 12, 2024, all privacy manifests you submit must have valid content. Keys and values in any privacy manifest must be in avalid format, For more details about privacy manifest files

The Privacyinfo.xcprivacy file from the following path is invalid:"Frameworks/AppAuth.framework/AppAuthCore Privacy.bundle/Privacyinfo.xcprivacy". in addition to the privacy manifest files in the locations outlined in the documentation, starting November 12. 2024. all privacy manifests you submit must have valid content. Keys and values in any privacy manifest must be in a valid format.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'product'
  2. Tap on 'archive'
  3. click 'attribute app'
  4. click ‘custom’
  5. click ‘apple store connect ’
  6. submit app
  7. See error

Environment

  • xcode 15.3
@zz-0io zz-0io added bug triage Issues that need to be triaged labels Oct 8, 2024
@zz-0io zz-0io changed the title Invalld privacy manifest Invalid privacy manifest Oct 10, 2024
@krazykriskomar
Copy link

krazykriskomar commented Oct 17, 2024

I second this! We use this package in our app and only have until 11/14 to fix the privacy issue.
I'm happy to help out here if you need it, just let me know.
If you are not going to be able to update the privacy manifest soon, would you mind posting here? We'll need to find another package if so.

@krazykriskomar
Copy link

I think literally hundreds of other packages, including most popular google sign in packages use this library. It'd be nice to know if you're not going to take action to correct this so that we can find an alternate.

@camden-king
Copy link

Thank you for reporting. Our team is investigating.

Are you able to clarify where you are getting AppAuth from? Is it CocoaPods or Swift Package Manager?

@krazykriskomar
Copy link

Cocoapods

@krazykriskomar
Copy link

Its all of the privacy info files that need filled in...
https://github.com/openid/AppAuth-iOS/blob/master/Sources/AppAuth/Resources/PrivacyInfo.xcprivacy

@krazykriskomar
Copy link

So, I think literally thousands of applications in some way depend on this library, and Apple is cutting off the ability to submit new app versions on 2024-11-14 that do not declare proper privacy policies, even in dependencies. Does anyone have an alternate that they've come across? Or at the least does anyone have an alternate to the google-sign-in library that uses this? We are coming dangerously close to the cutoff date.

@brnnmrls
Copy link
Collaborator

Thanks for the issue. We are taking a look. Apple requires that this library have a manifest, and so we have one at the relevant locations. Note that this library does not do any collection or tracking itself. Therefore, the manifest file has empty values for all required fields. Do you have a privacy manifest for your app? If not, then we suggest that you create one following the instructions here. Per this comment, it's the host app and its identity provider that do the tracking where host apps should declare their privacy impacting usage in their own privacy manifest files.

@krazykriskomar
Copy link

krazykriskomar commented Oct 29, 2024

We do have a privacy policy, yes. I'm basing my claim off of an email we get from Apple every time we submit that seems to call out your package.
image
Here are the links they call out:
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files and https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/adding_a_privacy_manifest_to_your_app_or_third-party_sdk.

@brnnmrls
Copy link
Collaborator

brnnmrls commented Oct 30, 2024

Thanks for the extra context, our team is further investigating.

In the meantime, I have a few questions that could help. What version of AppAuth are you using? In the past we've had validation issues that were fixed so I'm curious if it might be due to not updating the version. Additionally, are you using Google Sign-In (asking since GSI pulls in AppAuth)? If so, which version of GSI are you using?

@brnnmrls
Copy link
Collaborator

brnnmrls commented Oct 31, 2024

Curious if you're still running into this issue? In addition to ensuring that you are depending on the latest versions of GoogleSign-In and AppAuth, please also share as much information as possible as to how you're building your app. For example, can you also provide your Podfile and any other commands, etc. that you use to assemble your app? This all would help us be able to reproduce your issue on our end.

@krazykriskomar
Copy link

krazykriskomar commented Nov 4, 2024

We are using @react-native-google-signin/google-signin version 13.1.0 which uses AppAuth (1.7.5)
So, I don't know what happened, but Apple did not send us that same warning email for the last version we released (2024.11.1). 🤷‍♂️ I'll keep an eye out but perhaps this has resolved itself in some way?
It could have been because I added the @react-native-google-signin/google-signin package to our expo app.config.js file, therefor making expo pay attention to it and configure for it.

@brnnmrls
Copy link
Collaborator

brnnmrls commented Nov 4, 2024

Awesome, that's good to hear! I will be closing the issue, but feel free to reopen if the issue returns and there's something we can do on our end.

@brnnmrls brnnmrls closed this as completed Nov 4, 2024
@JaoMcs
Copy link

JaoMcs commented Nov 28, 2024

I had the same issue yesterday, does anyone have any updates on it?

@thaxz
Copy link

thaxz commented Dec 2, 2024

The same thing is happening here. When I try to upload to the App Store, I get the error: 'Invalid binary App Store appauth.' I'm using Carthage btw

@zz-0io
Copy link
Author

zz-0io commented Dec 18, 2024

Apple has specified that privacy manifest files must adhere to certain standards. Each dataType entry should include valid key, type, and description fields to clearly indicate the type and purpose of the data being used. Entries that are empty dictionaries (e.g., ) do not meet these requirements, as Apple cannot determine the specific purpose of such entries.

By removing the empty dictionaries and updating the PrivacyInfo.xcprivacy file to match the format , the Invalid privacy manifest issue was resolved upon uploading to Apple.

@zz-0io
Copy link
Author

zz-0io commented Dec 18, 2024

WechatIMG11
This is the PrivacyInfo.xcprivacy file from AppAuth before removing the empty dictionaries.

@zz-0io
Copy link
Author

zz-0io commented Jan 2, 2025

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

6 participants