-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude items from autosuggestions #889
Comments
i would like to work on it this issue , can you please assign ? |
i tried to add this approch in the
is this a valid apporch or it should be in a different file ? or any other imporved method ? |
@AffanShaikhsurab That's good but you're missing a detail: you have to ask for more items, as explained in the OP. |
can you please see if any changes needed to be done in the pr ? |
Why - Problem description
cf. openfoodfacts/smooth-app#5096 by @g123k:
What - Proposed solution
The first thing to do would be to add a parameter to the autosuggestion methods: a list of items to exclude.
Then, if the developer asks for 10 items and we exclude 2 items, we should ask the server for 10+2 = 12 items and return the first 10 items that are not in the 2-item list.
Alternatives you've considered
Of course if the server could accept a list of items to exclude it would be better.
The text was updated successfully, but these errors were encountered: