Skip to content

Remove Certificate step from SSL page? #160

@alexellis

Description

@alexellis
Member

Proposed change

We may be able to remove the additional create Certificate step from SSL page.. https://docs.openfaas.com/reference/ssl/kubernetes-with-cert-manager/

Context

It seems like cert-manager's Ingress shim (available since 0.2.2) automatically creates certificates if an Ingress object is decorated appropriately. This is simpler than us instructing the user to create a separate Certificate object.

Found by: @ajaegle

openfaas/ingress-operator#6

Your Environment

We should test that the certificate is created automatically before removing the explicit step.

Activity

LucasRoesler

LucasRoesler commented on Jul 1, 2019

@LucasRoesler
Member

I think we should remove it, but make sure to add a callout in the docs that this only "works for cert-manager 0.2.2+ when ingress-shim is installed, the default configuration." Or some other similar wording.

alexellis

alexellis commented on Jul 1, 2019

@alexellis
MemberAuthor

Whilst I appreciate the caution, we currently tell people to use cert-manager is at 0.7.0, so I don't think the notice is needed (for that reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @LucasRoesler@alexellis

        Issue actions

          Remove Certificate step from SSL page? · Issue #160 · openfaas/docs