-
Notifications
You must be signed in to change notification settings - Fork 99
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededsize/s
Description
Proposed change
We may be able to remove the additional create Certificate step from SSL page.. https://docs.openfaas.com/reference/ssl/kubernetes-with-cert-manager/
Context
It seems like cert-manager's Ingress shim (available since 0.2.2) automatically creates certificates if an Ingress object is decorated appropriately. This is simpler than us instructing the user to create a separate Certificate object.
Found by: @ajaegle
Your Environment
We should test that the certificate is created automatically before removing the explicit step.
ajaegle
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededsize/s
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
LucasRoesler commentedon Jul 1, 2019
I think we should remove it, but make sure to add a callout in the docs that this only "works for cert-manager 0.2.2+ when ingress-shim is installed, the default configuration." Or some other similar wording.
alexellis commentedon Jul 1, 2019
Whilst I appreciate the caution, we currently tell people to use cert-manager is at 0.7.0, so I don't think the notice is needed (for that reason).