Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup pre-commit hook for google-java-format #25

Open
cbeach47 opened this issue Jun 5, 2020 · 1 comment · May be fixed by #28
Open

Setup pre-commit hook for google-java-format #25

cbeach47 opened this issue Jun 5, 2020 · 1 comment · May be fixed by #28
Labels
help wanted Extra attention is needed

Comments

@cbeach47
Copy link
Contributor

cbeach47 commented Jun 5, 2020

No description provided.

@cbeach47 cbeach47 added the help wanted Extra attention is needed label Jun 5, 2020
@ChristianMurphy
Copy link
Member

https://github.com/gtramontina/ghooks.gradle and https://github.com/sherter/google-java-format-gradle-plugin/blob/master/contrib/pre-commit may offer a way to do this in pure Java/Gradle.

Or as a fallback, https://github.com/node-gradle/gradle-node-plugin could be used to embed Node, and https://github.com/typicode/husky could be used

ChristianMurphy added a commit to ChristianMurphy/openEQUELLA-toolbox that referenced this issue Jun 10, 2020
@ChristianMurphy
build: setup pre commit hook to check java format
811b162 
* updates gradle wrapper to latest version to enable ghooks to be used.
* enables ghooks plugin for gradle
* adds google java format pre commit hook
* adds test check file output to gitignore

resolves openequella#25
@ChristianMurphy ChristianMurphy linked a pull request Jun 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: setup pre commit hook to check java format ChristianMurphy/openEQUELLA-toolbox
2 participants
@ChristianMurphy @cbeach47