-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python script to find the python dependencies sources #509
Python script to find the python dependencies sources #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also add this to the set of runnable scripts: https://github.com/openedx/repo-tools/blob/master/setup.py#L91-L122
This will let you run this script after you install it via pip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add requirements-parser
to https://github.com/openedx/repo-tools/blob/master/edx_repo_tools/find_dependencies/extra.in so that we don't have to manually install it in workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the following testing an saw errors:
pip install -e '.[find_dependencies]'
find_python_dependencies # Expected to see the click help output.
find_python_dependencies --help # Also throws errors.
It also looks like the ignore_paths setting is not being used to actually ignore anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output is not quite right yet:
❯ find_python_dependencies --req-file ~/src/openedx/edx-platform/requirements/edx/base.txt --ignore https://github.com/mitodl/edx-sga
Second party packages:
https://github.com/edx/codejail-includes
https://github.com/edx/braze-client
https://github.com/edx/edx-name-affirmation
https://github.com/mitodl/edx-sga
https://github.com/edx/token-utils
https://github.com/open-craft/xblock-poll
If I'm only ignoring one of the packages, that one should not be listed, only the packages that are not being ignored should be listed.
c54e7ec
to
e0a5aeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of final suggestions, great job with all the back and forth.
fda069d
to
7446bdc
Compare
7f14755
to
65307d0
Compare
65307d0
to
75172eb
Compare
We are adding a new dependency script so bump the version in preparation for a release.
No description provided.